feat: add the NBS_API_PUB_KEY environment var#28
Merged
Conversation
alismx
requested changes
May 21, 2025
| type = string | ||
| description = "The public key used to validate the incoming authenication for the eCR Viewer API." | ||
| default = <<EOT | ||
| -----BEGIN PUBLIC KEY----- |
Collaborator
There was a problem hiding this comment.
@mcmcgrath13 Will you remove this default? We're going to add a value downstream.
Contributor
Author
There was a problem hiding this comment.
should I delete it for both nbs keys?
Contributor
Author
There was a problem hiding this comment.
pushed up deleting both - let me know if the original one needs restoring
alismx
requested changes
May 21, 2025
| kd+ONf43CmqDSTa3atSFq4sCAwEAAQ== | ||
| -----END PUBLIC KEY----- | ||
| EOT | ||
| } |
Collaborator
There was a problem hiding this comment.
Ah, we'll need an empty default so that we aren't required to fill in a prompt or pass something in when Terraform is run. My bad on the wording in my request!
default = ""
alismx
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the pattern for
NBS_PUB_KEYto add support for the api version of the pub key