refactor: remove database_type variable and update connection string …#31
Merged
refactor: remove database_type variable and update connection string …#31
Conversation
…conditionals - Remove the unused database_type variable definition. - Update local.tf to use secrets_manager versions for connection strings instead of database_type checks. - Adjust README.md to remove documentation for the database_type input.
mcmcgrath13
reviewed
May 27, 2025
| registry_password = data.aws_ecr_authorization_token.this.password | ||
| dibbs_repo = var.dibbs_repo | ||
| database_url = var.database_type == "postgresql" ? { | ||
| database_url = var.secrets_manager_postgresql_connection_string_version != "" ? { |
Contributor
There was a problem hiding this comment.
should we rename the variable to secrets_manager_database_connection_string_version or similar? since it isn't used only for postgres anymore
Collaborator
Author
There was a problem hiding this comment.
Great suggestion, I made this change in this follow-up! #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed
Testing