Add stop to CeedVectorSetValueStrided #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedbrown
reviewed
Mar 18, 2025
jeremylt
force-pushed
the
jeremy/strided-fix
branch
4 times, most recently
from
708312e to
5504ada
Compare
jedbrown
reviewed
Mar 19, 2025
Member
jedbrown
left a comment
jedbrown
left a comment
There was a problem hiding this comment.
Comments all untested, mostly trying to simplify.
jeremylt
force-pushed
the
jeremy/strided-fix
branch
2 times, most recently
from
7e6e7d9 to
21fc083
Compare
jeremylt
commented
Mar 19, 2025
Co-authored-by: Jed Brown <[email protected]>
jeremylt
force-pushed
the
jeremy/strided-fix
branch
from
1ace732 to
a637ca9
Compare
Merged
Member
Author
|
CI is happy, local testing with Ratel is happy. This is good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps fix a bug with AtPoints diagonal assembly