Added biharmonic example in libceed #1803
Conversation
|
This PR appears to be missing the corresponding hpp file with the QFunction source code like BP1 and BP3 have. |
|
Hi @aneeshs1729 , thank you for your contribution! |
jeremylt
left a comment
jeremylt
left a comment
There was a problem hiding this comment.
The contents of the files you added do not match how bp1 and bp3 were written. I'm not sure what example you are looking at, but you should look at bp1.cpp, bp1.h, and bp1.hpp in examples/mfem in the libCEED repository.
examples/mfem/biharmonic.cpp
Outdated
| // 11. destroy | ||
| CeedDestroy(&ceed); | ||
| return 0; | ||
| } No newline at end of file |
examples/mfem/biharmonic.h
Outdated
| void SaveSolution(const mfem::GridFunction &solution, const std::string &filename); | ||
| } | ||
|
|
||
| #endif // BIHARMONIC_H No newline at end of file |
There was a problem hiding this comment.
| #endif // BIHARMONIC_H | |
| #endif // BIHARMONIC_H | |
examples/mfem/biharmonic.hpp
Outdated
| void SaveSolution(const mfem::GridFunction &solution, const std::string &filename); | ||
| } | ||
|
|
||
| #endif // BIHARMONIC_HPP No newline at end of file |
There was a problem hiding this comment.
| #endif // BIHARMONIC_HPP | |
| #endif // BIHARMONIC_HPP | |
|
@aneeshs1729 , thank you for your work. Are you able to address the reviewer's comments? |
Hello Professor barra, |
| @@ -0,0 +1,17 @@ | |||
| #ifndef BIHARMONIC_HPP | |||
There was a problem hiding this comment.
Note - this file needs to resemble https://github.com/CEED/libCEED/blob/main/examples/mfem/bp3.hpp
| @@ -0,0 +1,20 @@ | |||
| #ifndef BIHARMONIC_H | |||
There was a problem hiding this comment.
Note - this file needs to resemble https://github.com/CEED/libCEED/blob/main/examples/mfem/bp3.h
| // libCEED + MFEM Example: BP1 | ||
| // | ||
| // This example illustrates a simple usage of libCEED with the MFEM (mfem.org) finite element library. | ||
| // | ||
| // The example reads a mesh from a file and solves a simple linear system with a mass matrix (L2-projection of a given analytic function provided by | ||
| // 'solution'). The mass matrix required for performing the projection is expressed as a new class, CeedMassOperator, derived from mfem::Operator. | ||
| // Internally, CeedMassOperator uses a CeedOperator object constructed based on an mfem::FiniteElementSpace. | ||
| // All libCEED objects use a Ceed device object constructed based on a command line argument (-ceed). |
There was a problem hiding this comment.
This biharmonic example is not a BP, so this description needs to be updated
| // ./biharmonic -m ../../../mfem/data/inline-segment.mesh -o 8 | ||
|
|
||
| /// @file | ||
| /// MFEM mass operator based on libCEED |
There was a problem hiding this comment.
this line also needs to be updated
|
Hi @aneeshs1729 , how are you? I was wondering if you intended to complete this PR or if there were any impeding issues that you encountered. There are a couple of other potential contributors that are eyeing this project and I was wondering if there was a missing interface for which this BP could not be completed or if it was just for personal reasons. Thank you! |
3 participants
Hello libCEED team
This PR is related to issue #1795. I'm happy to iterate on this further and open to any feedback or suggestions you have. Let me know if there are any style, structural, or interface adjustments you'd like to see!
Thanks a lot for your time