Adds a way to control chunkspan print formating by PaulGannay · Pull Request #1106 · CExA-project/ddc

PaulGannay · 2026-04-02T14:42:56Z

Should solve: #1059

PaulGannay · 2026-04-02T14:46:20Z

CI reports:

Run if grep -R "#include <iostream>" $(git ls-files 'src/*.[ch]pp'); then exit 1; fi
  if grep -R "#include <iostream>" $(git ls-files 'src/*.[ch]pp'); then exit 1; fi
  shell: /usr/bin/bash -e {0}
src/ddc/print.cpp:#include <iostream>
Error: Process completed with exit code 1.

iostream is included but in a .cpp file which won't be visible to the end user, this check looks like it was written when the library was header only?

PaulGannay · 2026-04-02T14:54:56Z

src/ddc/print.cpp

    std::unique_ptr<char, decltype(std::free)*> const
            demangled_name(abi::__cxa_demangle(mangled_name, nullptr, nullptr, &status), std::free);
    if (status != 0) {
        os << "Error demangling dimension name: " << status;
        return;
    }


This should maybe be changed to output th error to cerr?
And only print Unknown type to os?

I agree about outputing to cerr, I wonder how we can test that ? Should we pass a second std::ostream ?

What about printing the given mangled_name ?

What about printing the given mangled_name ?

You are right, this is a better solution

I agree about outputing to cerr, I wonder how we can test that ? Should we pass a second std::ostream ?

I don't think we need to test the output to cerr, testing that we get the expected mangled type back should be enough?

codecov · 2026-04-02T15:17:19Z

Codecov Report

❌ Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.87%. Comparing base (24f77da) to head (203f871).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ddc/print.hpp	95.12%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   94.90%   94.87%   -0.03%     
==========================================
  Files          64       64              
  Lines        2844     2871      +27     
  Branches      893      909      +16     
==========================================
+ Hits         2699     2724      +25     
  Misses         95       95              
- Partials       50       52       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tpadioleau · 2026-04-03T07:26:50Z

CI reports:
Run if grep -R "#include <iostream>" $(git ls-files 'src/*.[ch]pp'); then exit 1; fi
  if grep -R "#include <iostream>" $(git ls-files 'src/*.[ch]pp'); then exit 1; fi
  shell: /usr/bin/bash -e {0}
src/ddc/print.cpp:#include <iostream>
Error: Process completed with exit code 1.
iostream is included but in a .cpp file which won't be visible to the end user, this check looks like it was written when the library was header only?

I agree, the grep applies to .cpp source files but I it seems too restrictive. Let me update that rule.

tpadioleau

Overall good for me. What do you think of making getInstance a free function and making the constructor a public function ? That would allow to make ChunkPrinter independent of the singleton.

tpadioleau · 2026-04-03T07:35:33Z

src/ddc/print.cpp

    std::unique_ptr<char, decltype(std::free)*> const
            demangled_name(abi::__cxa_demangle(mangled_name, nullptr, nullptr, &status), std::free);
    if (status != 0) {
        os << "Error demangling dimension name: " << status;
        return;
    }


I agree about outputing to cerr, I wonder how we can test that ? Should we pass a second std::ostream ?

What about printing the given mangled_name ?

tpadioleau · 2026-04-03T07:38:17Z

src/ddc/print.cpp

+{
+    // Ensure that m_edgeitems < (m_threshold / 2) stays true.
+    ddc::detail::ChunkPrinter& printer = ddc::detail::ChunkPrinter::getInstance();
+    printer.m_global_lock.lock();


If I remember correctly there is a RAII version of locking in the standard, could be useful in case an exception happens before unlock ?

src/ddc/print.cpp

src/ddc/print.hpp

tpadioleau · 2026-04-03T07:50:18Z

src/ddc/print.hpp

+
+
+    ddc::detail::ChunkPrinter& printer = ddc::detail::ChunkPrinter::getInstance();
+    printer.m_global_lock.lock();


Should locking be hidden in the member functions ?

It is better to lock in print_type_info to ensure that the metadata and the content of the chunkspan get printed together.

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

- full_print function to always print full array ignoring options - use struct to set the options in order to use designated initializers - use scoped_lock instead of lock_guard to follow linter recommendation Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

Adds a way to control chunkspan print formating

231668d

PaulGannay requested a review from tpadioleau as a code owner April 2, 2026 14:42

PaulGannay commented Apr 2, 2026

View reviewed changes

tpadioleau requested changes Apr 3, 2026

View reviewed changes

PaulGannay and others added 3 commits April 3, 2026 10:34

Apply suggestions from code review

85f21e2

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

Add tests to improve coverage, apply review suggestion

af634b7

Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

Spell check

5cd2ab3

Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

PaulGannay force-pushed the print_option branch 4 times, most recently from 1d7c026 to 1224d78 Compare April 3, 2026 13:55

PaulGannay force-pushed the print_option branch from 1224d78 to e5be948 Compare April 3, 2026 13:56

fix linter remarks

203f871

Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

PaulGannay force-pushed the print_option branch from 98218c6 to 203f871 Compare April 3, 2026 17:49



		ddc::detail::ChunkPrinter& printer = ddc::detail::ChunkPrinter::getInstance();
		printer.m_global_lock.lock();

Conversation

PaulGannay commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaulGannay commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaulGannay Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

tpadioleau Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

PaulGannay Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tpadioleau commented Apr 3, 2026

Uh oh!

tpadioleau left a comment

Choose a reason for hiding this comment

Uh oh!

tpadioleau Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

tpadioleau Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tpadioleau Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

PaulGannay Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PaulGannay commented Apr 2, 2026 •

edited

Loading

PaulGannay commented Apr 2, 2026 •

edited

Loading

PaulGannay Apr 3, 2026 •

edited

Loading

codecov bot commented Apr 2, 2026 •

edited

Loading