Regroup data: scripts and function updates

[gdamiand]

Please use the following template to help us managing pull requests.

Summary of Changes

Start to regroup all data in a same global directory (for now only for LCC package).
Add a global function that computes the name of a data file using either a macro defined by cmake, or an environement variable.

Plan for Data

• Move all data of examples in the directory Data/data/XXX (XXX being meshes, polylines, points_2, points_3)

Release Management

• Affected package(s): LCC (for now)
• Link to small feature here -- pre-approval date: 2021/01/18

TODOs

• Try to remove .cmd files in examples
• Write a script detecting duplicated files and moving them + updating examples/tests using them
• write get_data_file_path() that will warn the user when the file does not exists + print CGAL_DATA_DIR

[sloriot]

@gdamiand What about not moving all the files, but only general OFF/OBJ/STL/XXX ? Everything that is specific to a test or example can stay where it is. What do you think?

[gdamiand]

I agree.

[lrineau]

@maxGimeno Once the CMake testsuite is done (issue #4826), I would like we take over this PR to resurrect it. But I think we can only do it correctly once the CMake testsuite is there: we will add a test or example that uses the get_data() function in the set of programs that are run automatically by the CMake testsuite.

[gdamiand]

Thanks @lrineau ; I agree to resurrect this PR.

Before we should discuss a little bit about the directories we want. I will create a small feature for that.

[gdamiand]

Cf this small feature to discuss about naming and directories
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Regroup_data

[gdamiand]

@maxGimeno @lrineau cf. my updated proposal for data in the wiki.

[sloriot]

@gdamiand I think it requires a second round as some decisions have already been taken from the discussion, Laurent even suggested a new name for the function.

[gdamiand]

@gdamiand I think it requires a second round as some decisions have already been taken from the discussion, Laurent even suggested a new name for the function.

Done.

[maxGimeno]

There are conflicts

[gdamiand]

There are conflicts

I will solve them later; we need first to decide what to do on the wiki small feature page.

[sloriot]

@gdamiand no work should be done to move files before #4255 is integrated. In particular this branch uses uppercase OFF, STL, PLY IIRC, so it might be good to respect that for the hierarchy. We can have a live meeting once the small feature is approved to discuss the details and who is doing what.

[gdamiand]

@gdamiand no work should be done to move files before #4255 is integrated. In particular this branch uses uppercase OFF, STL, PLY IIRC, so it might be good to respect that for the hierarchy. We can have a live meeting once the small feature is approved to discuss the details and who is doing what.

Ok @sloriot , thanks !

[sloriot]

@gdamiand let me know when you want to have a meeting about this feature.

[sloriot]

I'll have a look.

[sloriot]

After trying hard I could reproduce the error locally.
ERROR: Cannot run test script, please set the variable CGAL_DATA_DIR

I just know have to fix it (should not be hard).

[gdamiand]

congratulation @sloriot !! (one day, we should modify/simplify our test suite...)

[sloriot]

I could make the testsuite locally working

[gdamiand]

I could make the testsuite locally working

Thanks @sloriot !!!

[sloriot]

Successfully tested in CGAL-5.4-Ic-57

[gdamiand]

Successfully tested in CGAL-5.4-Ic-57

Congratulation !!

[afabri]

Is it documented what that means for developers? Does it mean something for data directories in example directories....

[sloriot]

Please wait for the other PR that is doing the dirty part. This one was only about scripts and function. (#5427)