Code Quality: Address shadowing #840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kheaactua
commented
Jan 28, 2025
kheaactua
commented
- Addresses most shadowing variables
- Fixes some old style C-casts
goncaloalmeida
approved these changes
Feb 12, 2025
implementation/service_discovery/src/service_discovery_impl.cpp
Outdated
Show resolved
Hide resolved
kheaactua
force-pushed
the
shadowing
branch
2 times, most recently
from
b29d9b3 to
fb06964
Compare
implementation/endpoints/src/local_tcp_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
implementation/endpoints/src/local_tcp_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
Swapped to a static_cast
Swapped to a static_cast
Switched to scoped_lock
Switched to scoped_lock
Switched to scoped_lock
…wing Switched to scoped_lock
…s shadowing Switched to scoped_lock
… Address shadowing Switched to scoped_lock
…uality: Address shadowing Switched to scoped_lock
…! Code Quality: Address shadowing Removed redundant converters
implementation/endpoints/src/local_uds_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
…! fixup! Code Quality: Address shadowing
implementation/endpoints/src/local_tcp_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
…p! fixup! fixup! Code Quality: Address shadowing Removed explicit template from unique_ptr
…up! fixup! fixup! fixup! Code Quality: Address shadowing Removed explicit template from scoped_lock in files already changed in this commit
implementation/endpoints/src/local_uds_server_endpoint_impl.cpp
Outdated
Show resolved
Hide resolved
| @@ -950,7 +950,7 @@ void local_uds_server_endpoint_impl::print_status() { | |||
| std::lock_guard<std::mutex> its_lock(mutex_); | |||
| connections_t its_connections; | |||
| { | |||
| std::lock_guard<std::mutex> its_lock(connections_mutex_); | |||
| std::lock_guard<std::mutex> its_lock_inner(connections_mutex_); | |||
There was a problem hiding this comment.
Suggested change
| std::lock_guard<std::mutex> its_lock_inner(connections_mutex_); | |
| std::scoped_lock its_lock_inner{connections_mutex_}; |
There was a problem hiding this comment.
Fixed in b856ea89
…up! fixup! fixup! fixup! fixup! Code Quality: Address shadowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.