Fixes to json exporter - #473
Merged
Merged
Conversation
Signed-off-by: Eric Montellese <eric.montellese@hologic.com>
Signed-off-by: Eric Montellese <eric.montellese@hologic.com>
Signed-off-by: Eric Montellese <eric.montellese@hologic.com>
erikbosch
reviewed
Dec 8, 2025
|
|
||
| root_key: str | None | ||
| root_key = next(iter(signals_data)) | ||
| if root_key is None: |
Collaborator
There was a problem hiding this comment.
So here we take first name found right? Do we need to check that there are not more names/roots or is that already covered by some other checks?
Collaborator
There was a problem hiding this comment.
Signals data will look like that:
signals_data = {tree.name: get_data(tree, extend_all_attributes, extended_attributes)}But yeah, we probably should check for the size and throw an error when its > 1 to notice that something is going wrong
sschleemilch
reviewed
Dec 8, 2025
|
|
||
| root_key: str | None | ||
| root_key = next(iter(signals_data)) | ||
| if root_key is None: |
Collaborator
There was a problem hiding this comment.
Signals data will look like that:
signals_data = {tree.name: get_data(tree, extend_all_attributes, extended_attributes)}But yeah, we probably should check for the size and throw an error when its > 1 to notice that something is going wrong
Collaborator
|
MoM:
|
Collaborator
|
MoM: Merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.