Skip to content

Fixes to json exporter #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikbosch merged 3 commits into from
Dec 16, 2025
Merged

Fixes to json exporter #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42c7d77
Set stats-radial default to None
eric-hologic Dec 1, 2025
a368a7a
Discover root node name (vs. assuming 'Vehicle')
eric-hologic Dec 4, 2025
f75b2bc
Copy type and description information for branches
eric-hologic Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vss_tools/exporters/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def get_data(node: VSSNode, with_extra_attributes: bool = True, extended_attribu
@click.option(
"--stats-radial",
type=click.Path(path_type=Path),
default=None,
Comment thread
sschleemilch marked this conversation as resolved.
help="Generate radial tree statistics into following JSON file",
)
@click.pass_context
Expand Down
16 changes: 13 additions & 3 deletions src/vss_tools/exporters/stats_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,13 @@ def process_piechart_stats(data_metadata: pd.DataFrame, output: Path, old_chart:
def process_radial_stats(signals_data: dict[str, Any], output: Path) -> None:
"""Process data for radial tree statistics."""

root_key: str | None
root_key = next(iter(signals_data))
if root_key is None:

@erikbosch erikbosch Dec 8, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here we take first name found right? Do we need to check that there are not more names/roots or is that already covered by some other checks?

@sschleemilch sschleemilch Dec 8, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signals data will look like that:

    signals_data = {tree.name: get_data(tree, extend_all_attributes, extended_attributes)}

But yeah, we probably should check for the size and throw an error when its > 1 to notice that something is going wrong

raise KeyError("No root node with children found in signals data")

children = []
stack = [{"key": key, "value": value, "parent": None} for key, value in signals_data["Vehicle"]["children"].items()]
stack = [{"key": key, "value": value, "parent": None} for key, value in signals_data[root_key]["children"].items()]

while stack:
current = stack.pop()
Expand All @@ -91,6 +96,11 @@ def process_radial_stats(signals_data: dict[str, Any], output: Path) -> None:
item = {"name": key}
if "children" in value:
item["children"] = []
# Copy type and description for branches too
if "type" in value:
item["type"] = value["type"]
if "description" in value:
item["description"] = value["description"]
stack.extend(
{"key": child_key, "value": child_value, "parent": item["children"]}
for child_key, child_value in value["children"].items()
Expand All @@ -113,8 +123,8 @@ def process_radial_stats(signals_data: dict[str, Any], output: Path) -> None:
stack.extend(child for child in current["children"] if "children" in child)

radial_tree_data = {
"name": "Vehicle",
"type": "Vehicle",
"name": root_key,
"type": root_key,
"children": children,
}

Expand Down