Make it possible to build simple VM images as part of the CheriBSD release process

[brooksdavis]

I've not tested the image yet, but the right rc.conf bits seem to be there in the source root directory.

It would be better if we could run ldconfig more directly since it should now work for cross builds since f221df6. Likewise non-root package support.

[bsdjhb]

It might be worth adding a new newaliases rc.d script conditional on firstboot to run newaliases if needed?

Hmm, looks like /etc/rc.d/sendmail already runs newaliases if needed, but only if sendmail is enabled. I wonder if that part should just move out to a dedicated /etc/rc.d/newaliases script.

[brooksdavis]

I've written one (https://reviews.freebsd.org/D49309) but it turns out to be mostly pointless because the in the default install newaliases uses dma which doesn't build an aliases.db at all (it just validates its arguments and returns 0).

[brooksdavis]

I've cherry picked everything needed to avoid conflicts when cherry picking the upstream versions of relevant commits. We're not quite in sync with upstream as I skipped a few like the chain of wireless firmware changes that didn't cause conflicts and the profiled libraries change which is very broad.

[brooksdavis]

I've been able to boot a BASIC-CI vm image created this way

[kwitaszczyk]

There is a couple of issues when trying to use this on Ubuntu (technos in my case):

/local/scratch/kw543/repos/cheribsd/release-vm-images/release/scripts/mk-vmimage.sh: 56: /local/scratch/kw543/repos/cheribsd/release-vm-images/release/tools/vmimage.subr: Syntax error: "}" unexpected

which can be fixed with

diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr
index 2d81da93794f..b9400784aabb 100644
--- a/release/tools/vmimage.subr
+++ b/release/tools/vmimage.subr
@@ -53,6 +53,7 @@ vm_create_base() {
 
 vm_copy_base() {
        # Defunct
+       return 0
 }
 
 vm_install_base() {

date: invalid option -- 'v'                                                                                                                                                                                    
Try 'date --help' for more information.                                                                                                                                                                        
bmake: "/local/scratch/kw543/repos/cheribsd/release-vm-images/release/Makefile.azure" line 21: warning: Command "date -v-1d -I -u" exited with status 1

which can be worked around in our case with

diff --git a/release/Makefile.vm b/release/Makefile.vm
index 1f56bdb03f97..76fede193a32 100644
--- a/release/Makefile.vm
+++ b/release/Makefile.vm
@@ -282,10 +282,12 @@ cloudware-release:        ${CLOUDTARGETS}
 cloudware-release:
 .endif
 
+.if !defined(WITHOUT_QEMU)
 .include "${.CURDIR}/Makefile.azure"
 .include "${.CURDIR}/Makefile.ec2"
 .include "${.CURDIR}/Makefile.firecracker"
 .include "${.CURDIR}/Makefile.gce"
 .include "${.CURDIR}/Makefile.oracle"
 .include "${.CURDIR}/Makefile.vagrant"
+.endif
 .include "${.CURDIR}/Makefile.inc1"

ln: failed to access 'basic-ci.ufs.raw': No such file or directory

*** Failed target:  cw-basic-ci-raw
*** Failed command: ln -f basic-ci.ufs.raw basic-ci.raw
*** Error code 1

which I have not got to the bottom of.

[brooksdavis]

https://reviews.freebsd.org/D49526 and https://reviews.freebsd.org/D49527 address first two issues. (I contemplated gating Azure support on the host being FreeBSD, but it seemed annoying to do in a way that wasn't transparent.)