Skip to content

[ENG-7572] [ENG-7797] [ENG-7859] VRL - Unit tests for GV: M1 & M2 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[ENG-7572] [ENG-7797] [ENG-7859] VRL - Unit tests for GV: M1 & M2 #277

wants to merge 7 commits into from

Conversation

Vlad0n20
Copy link
Contributor

@Vlad0n20 Vlad0n20 commented May 2, 2025

No description provided.

@Vlad0n20 Vlad0n20 force-pushed the feature/ENG-7859 branch from 6d268fd to d84ed75 Compare May 2, 2025 14:47
@Vlad0n20 Vlad0n20 force-pushed the feature/ENG-7859 branch from d84ed75 to 7ef26aa Compare May 2, 2025 15:07
@cslzchen cslzchen changed the title [ENG-7859] Feature/eng 7859 add tests for Dataverse imp as linked addon [ENG-7859] Add tests for Dataverse imp as linked addon May 2, 2025
@cslzchen cslzchen mentioned this pull request May 2, 2025
Closed
@cslzchen cslzchen changed the title [ENG-7859] Add tests for Dataverse imp as linked addon [ENG-7572] [ENG-7797] [ENG-7859] M1 & M2 Unit Tests May 12, 2025
cslzchen
cslzchen reviewed May 12, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

I see changes in this c7730b6 commit is missing in this PR, do we no longer need it? Please double check.

@Vlad0n20
Copy link
Contributor Author

Looks good overall.

I see changes in this c7730b6 commit is missing in this PR, do we no longer need it? Please double check.

Yeah it is no longer necessary

cslzchen
cslzchen approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@cslzchen cslzchen changed the title [ENG-7572] [ENG-7797] [ENG-7859] M1 & M2 Unit Tests [ENG-7572] [ENG-7797] [ENG-7859] VRL - Unit tests for GV: M1 & M2 May 21, 2025
@cslzchen cslzchen mentioned this pull request May 23, 2025
Open
@cslzchen
Copy link
Collaborator

PR will be merged along with #288

@cslzchen cslzchen closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlad0n20 @cslzchen