-
Notifications
You must be signed in to change notification settings - Fork 13
[ENG-7572] [ENG-7797] [ENG-7859] [ENG-7982] [ENG-8024] VRL - Unit tests for GV M1 & M2 #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vlad0n20
wants to merge
24
commits into
CenterForOpenScience:feature/verified-resource-linking
Choose a base branch
from
Vlad0n20:feature/ENG-7982
base: feature/verified-resource-linking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ENG-7572] [ENG-7797] [ENG-7859] [ENG-7982] [ENG-8024] VRL - Unit tests for GV M1 & M2 #288
Vlad0n20
wants to merge
24
commits into
CenterForOpenScience:feature/verified-resource-linking
from
Vlad0n20:feature/ENG-7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix serializer naming * All fields are read-only
Co-authored-by: Yuhuai Liu <[email protected]>
Co-authored-by: Yuhuai Liu <[email protected]>
375f7c5
to
809550c
Compare
809550c
to
abf3553
Compare
cslzchen
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and forced push back to get rid of unnecessary and conflicting commits.
PR looks good. I will do a final CR and merge after the last batch of updates come in.
abf3553
to
518545b
Compare
518545b
to
17e00b2
Compare
hmm ... it seems those duplicate/conflicting commits come back, I will fix it again and push back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Include changes from #277