Skip to content

[ENG-7572] [ENG-7797] [ENG-7859] [ENG-7982] [ENG-8024] VRL - Unit tests for GV M1 & M2 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: feature/verified-resource-linking
Choose a base branch
from

Conversation

Vlad0n20
Copy link
Contributor

@Vlad0n20 Vlad0n20 commented May 19, 2025

Note

Include changes from #277

@Vlad0n20 Vlad0n20 changed the title [ENG-79832] - New tests for features [ENG-7982] - New tests for features May 19, 2025
@cslzchen cslzchen changed the title [ENG-7982] - New tests for features [ENG-7982] VRL - Unit tests for GV: M2 Updates May 21, 2025
@Vlad0n20 Vlad0n20 force-pushed the feature/ENG-7982 branch from 375f7c5 to 809550c Compare May 22, 2025 13:00
@cslzchen cslzchen force-pushed the feature/ENG-7982 branch from 809550c to abf3553 Compare May 23, 2025 13:08
@cslzchen cslzchen changed the title [ENG-7982] VRL - Unit tests for GV: M2 Updates [ENG-7572] [ENG-7797] [ENG-7859] [ENG-7982] VRL - Unit tests for GV M1 & M2 May 23, 2025
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and forced push back to get rid of unnecessary and conflicting commits.

PR looks good. I will do a final CR and merge after the last batch of updates come in.

@Vlad0n20 Vlad0n20 force-pushed the feature/ENG-7982 branch from abf3553 to 518545b Compare May 27, 2025 12:24
@Vlad0n20 Vlad0n20 changed the title [ENG-7572] [ENG-7797] [ENG-7859] [ENG-7982] VRL - Unit tests for GV M1 & M2 [ENG-7572] [ENG-7797] [ENG-7859] [ENG-7982] [ENG-8024] VRL - Unit tests for GV M1 & M2 May 27, 2025
@Vlad0n20 Vlad0n20 force-pushed the feature/ENG-7982 branch from 518545b to 17e00b2 Compare May 27, 2025 13:47
@cslzchen
Copy link
Collaborator

cslzchen commented Jun 3, 2025

hmm ... it seems those duplicate/conflicting commits come back, I will fix it again and push back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants