Conversation
…erent approach instead.
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
j9liu
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequel to #1256. This pull request fixes a few standing issues with GeoJSON rasterization:
expandToIncludePositionwould mean the bounding box would never encompass the full globe no matter how many points were in your document. GlobeRectangle calculation has been changed to handle this (which has introduced other far more minor issues as a result - see below). This means this PR closes GeoJSON Rasterization issues at anti-meridian #1275.The above issues have been fixed. In the course of doing so, we've introduced a few small edge cases which we've decided are at this point not worth the time to fix. For future reference, they are:
LineWidthMode::Meterswill have its width factored in when building the quadtree instead of when rendering the quadtree. This is more efficient but can cause issues with geometry near the antimeridian. This is because we grow the bounding rectangle of the geometry based on the width in meters, but this can cause it to grow past the antimeridian and produce a rectangle whichGlobeRectangle::computeUnionwill mangle. The solution here is to either come up with a smarter way of growing the bounding rectangle that produces a rectanglecomputeUnionwill accept, or handlingLineWidthMode::Metersthe same as handlingLineWidthMode::Pixelsand do it all at render time.radiansToPointinVectorRasterizer.cppdoesn't understand these coordinates, and two,CesiumGeospatial::GlobeRectangle::computeIntersectionfails when one rectangle crosses the antimeridian and the other exactly touches it. #1301 means that raster overlay tiles adjacent to the antimeridian will not be considered to include the document bounding rectangle that crosses the antimeridian, even though it should.