-
Notifications
You must be signed in to change notification settings - Fork 262
Fix more GeoJSON rasterization issues #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+626
−73
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2dbdbc8
Attempts to include width in quadtree calculations. Going with a diff…
azrogers cfc848b
Reimplementation of the quadtree... this went nowhere
azrogers 6f0fb3a
Pixel line widths has FINALLY been factored in.
azrogers 8389c8e
More tests while I try to figure out what else is wrong here.
azrogers 26b5bf6
Meters test working, equator test not...
azrogers d12719e
Equator antimeridian test now works... don't know why
azrogers 16416f9
Improve antimeridian handling
azrogers 5590dd5
Improve improved antimeridian handling
azrogers d0cc610
No more BoundingRegionBuilder for geometry rects
azrogers 7b51d9f
Format
azrogers acdff61
Merge branch 'main' of github.com:CesiumGS/cesium-native into geojson…
azrogers 8dba558
Update CHANGES.md
azrogers c23560a
clang-tidy fixes
azrogers 51ba1ce
Merge branch 'main' into geojson-fixes
j9liu e2a31da
Update CesiumNativeTests/src/checkFilesEqual.cpp
azrogers d5cf3ec
Update CHANGES.md
azrogers 4e7ef09
Update CesiumRasterOverlays/src/GeoJsonDocumentRasterOverlay.cpp
azrogers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
CesiumNativeTests/include/CesiumNativeTests/checkFilesEqual.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #pragma once | ||
|
|
||
| #include <filesystem> | ||
|
|
||
| namespace CesiumNativeTests { | ||
| /** | ||
| * @brief Tests that the contents of `fileA` are equal to the contents of | ||
| * `fileB`. | ||
| */ | ||
| void checkFilesEqual( | ||
| const std::filesystem::path& fileA, | ||
| const std::filesystem::path& fileB); | ||
| } // namespace CesiumNativeTests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #include <CesiumNativeTests/checkFilesEqual.h> | ||
| #include <CesiumNativeTests/readFile.h> | ||
|
|
||
| #include <doctest/doctest.h> | ||
|
|
||
| #include <cstddef> | ||
| #include <filesystem> | ||
| #include <vector> | ||
|
|
||
| namespace CesiumNativeTests { | ||
| void checkFilesEqual( | ||
| const std::filesystem::path& fileA, | ||
| const std::filesystem::path& fileB) { | ||
| const std::vector<std::byte>& bytes = readFile(fileA); | ||
| const std::vector<std::byte>& bytes2 = readFile(fileB); | ||
|
|
||
| REQUIRE(bytes.size() == bytes2.size()); | ||
| for (size_t i = 0; i < bytes.size(); i++) { | ||
| CHECK(bytes[i] == bytes2[i]); | ||
| } | ||
azrogers marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } // namespace CesiumNativeTests | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.