MSVC PageList next/prev bug fix#1319
Merged
azrogers merged 2 commits intoCesiumGS:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
|
Thanks for the change @calebbuffa! Just wondering, are you using this for iTwin? That's what the class was designed for, and why it's living in |
Contributor
Author
Thank you for the quick PR! I'm actually working on Python bindings for this repo, and because pybind11 requires specific instances of templates I ran into these errors - but I would agree a more general class would be helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1317. Only two lines changed, PagedList.h would fail to compile with MSVC if a user initialized their own PagedList. The fix was to initialize with
ErrorList{}instead ofnullopt.Please let me know if I need to do anything else for this PR. I have signed the CLA.