Skip to content

MSVC PageList next/prev bug fix #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azrogers merged 2 commits into from
Mar 10, 2026
+7 −4
Merged

MSVC PageList next/prev bug fix #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2efb01
next/prev initialize Resolved Future with ErrorList{} instead of nullopt
calebbuffa Mar 10, 2026
409e9c7
Format, update CHANGES.md
azrogers Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
##### Fixes :wrench:

- `Cesium3DTilesetSelection::Tileset::getRootTileAvailableEvent` will now resolve even when a `Tileset` is constructed with invalid source parameters, instead of hanging indefinitely.
- Fixed compilation error with MSVC when using custom `CesiumITwinClient::PagedList` types.

### v0.58.0 - 2026-03-02

Expand Down
10 changes: 6 additions & 4 deletions CesiumITwinClient/include/CesiumITwinClient/PagedList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ template <typename T> class PagedList {
CesiumAsync::Future<CesiumUtility::Result<PagedList<T>>>
next(CesiumAsync::AsyncSystem& asyncSystem, Connection& connection) const {
if (!this->_nextUrl.has_value()) {
return asyncSystem.createResolvedFuture(
CesiumUtility::Result<PagedList<T>>(std::nullopt));
return asyncSystem
.createResolvedFuture<CesiumUtility::Result<PagedList<T>>>(
CesiumUtility::Result<PagedList<T>>(CesiumUtility::ErrorList{}));
}

return _operation(connection, *this->_nextUrl);
Expand All @@ -145,8 +146,9 @@ template <typename T> class PagedList {
CesiumAsync::Future<CesiumUtility::Result<PagedList<T>>>
prev(CesiumAsync::AsyncSystem& asyncSystem, Connection& connection) const {
if (!this->_prevUrl.has_value()) {
return asyncSystem.createResolvedFuture(
CesiumUtility::Result<PagedList<T>>(std::nullopt));
return asyncSystem
.createResolvedFuture<CesiumUtility::Result<PagedList<T>>>(
CesiumUtility::Result<PagedList<T>>(CesiumUtility::ErrorList{}));
}

return _operation(connection, *this->_prevUrl);
Expand Down
Loading