chore: move utils/validator.zig → validator.zig#321
chore: move utils/validator.zig → validator.zig#321markolazic01 wants to merge 1 commit intoChainSafe:mainfrom
utils/validator.zig → validator.zig#321Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a structural refactoring by moving the validator utility file to a higher-level directory within the state transition module. This change necessitates updating numerous import paths throughout the project to ensure consistency and maintainability. The move is part of a broader effort to organize the codebase more effectively. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by moving validator.zig from the utils directory to the parent state_transition directory, which required updating import paths across numerous files. A review comment identifies a style guide violation in the moved validator.zig file where an import line exceeds the 100-column limit.
| const EpochCache = @import("./cache/epoch_cache.zig").EpochCache; | ||
| const WithdrawalCredentials = types.primitive.Root.Type; | ||
| const hasCompoundingWithdrawalCredential = @import("./electra.zig").hasCompoundingWithdrawalCredential; | ||
| const hasCompoundingWithdrawalCredential = @import("./utils/electra.zig").hasCompoundingWithdrawalCredential; |
There was a problem hiding this comment.
This line exceeds the 100-column limit specified in the repository style guide. Please wrap the import to adhere to the typographic measure constraints.
const electra_utils = @import("./utils/electra.zig");
const hasCompoundingWithdrawalCredential = electra_utils.hasCompoundingWithdrawalCredential;
References
- Hard limit all line lengths, without exception, to at most 100 columns for a good typographic 'measure'. Use it up. Never go beyond. (link)
There was a problem hiding this comment.
Seems like an unrelated change request as the repo generally does not follow this rule, I guess it should be formatted as a whole some time later.
Will leave as is.
|
@markolazic01 thanks for contribution, refer to #187 currently paused, try to pick other task |
2 participants
chore: move
utils/validator.zig→validator.zigPart of #169
Changes
src/state_transition/utils/validator.zigtosrc/state_transition/validator.zigblock/,epoch/,slot/,cache/, andutils/to reference the new locationvalidator.zigitself (EpochCache,hasCompoundingWithdrawalCredential) to reflect the new directory levelutils_test_root.zig, consistent with how previous moves in this effort were handledBuilds and compiles cleanly.
AI disclosure: Claude was consulted for reviewing the diff and drafting this description. All code changes were authored manually.