chore: move utils/epoch.zig → epoch.zig#322
chore: move utils/epoch.zig → epoch.zig#322markolazic01 wants to merge 1 commit intoChainSafe:mainfrom
utils/epoch.zig → epoch.zig#322Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project structure by moving the epoch-related utility file to a more appropriate location within the state transition module. This change improves the logical organization of the codebase and requires updating numerous import statements throughout the repository to ensure continued compatibility and build success. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by moving epoch.zig from the utils directory to the state_transition root, requiring import path updates across multiple files. The review feedback highlights two violations of the repository's 100-column line length limit in process_consolidation_request.zig and anchor_checkpoint.zig resulting from these import changes.
| const isPubkeyKnown = electra_utils.isPubkeyKnown; | ||
| const switchToCompoundingValidator = electra_utils.switchToCompoundingValidator; | ||
| const computeConsolidationEpochAndUpdateChurn = @import("../utils/epoch.zig").computeConsolidationEpochAndUpdateChurn; | ||
| const computeConsolidationEpochAndUpdateChurn = @import("../epoch.zig").computeConsolidationEpochAndUpdateChurn; |
There was a problem hiding this comment.
This line exceeds the 100-column limit (113 characters), which is a violation of the repository style guide. Grouping the import can help resolve this while maintaining clarity.
const epoch_utils = @import("../epoch.zig");
const computeConsolidationEpochAndUpdateChurn = epoch_utils.computeConsolidationEpochAndUpdateChurn;
References
- Hard limit all line lengths, without exception, to at most 100 columns. (link)
| const c = @import("constants"); | ||
| const ZERO_HASH = c.ZERO_HASH; | ||
| const computeCheckpointEpochAtStateSlot = @import("./epoch.zig").computeCheckpointEpochAtStateSlot; | ||
| const computeCheckpointEpochAtStateSlot = @import("../epoch.zig").computeCheckpointEpochAtStateSlot; |
There was a problem hiding this comment.
This line exceeds the 100-column limit (101 characters). Following the repository style guide, all lines must be at most 100 columns. Consider grouping the import to reduce line length.
const epoch_utils = @import("../epoch.zig");
const computeCheckpointEpochAtStateSlot = epoch_utils.computeCheckpointEpochAtStateSlot;
References
- Hard limit all line lengths, without exception, to at most 100 columns. (link)
There was a problem hiding this comment.
Seems like an unrelated change request as the repo generally does not follow this rule, I guess it should be formatted as a whole some time later.
Will leave as is.
chore: move
utils/epoch.zig→epoch.zigPart of #169
Changes
src/state_transition/utils/epoch.zigtosrc/state_transition/epoch.zigblock/,epoch/,slot/,cache/,signature_sets/,utils/,root.zig, andstate_transition.zigepoch.zigitself (EpochCache,getActivationExitChurnLimit,getConsolidationChurnLimit)utils_test_root.zig, consistent with how previous moves in this effort were handledepoch_cache.zig:../utils//epoch_shuffling.zig→../utils/epoch_shuffling.zigNote: this PR keeps the validator import in
epoch.zigas./utils/validator.zigso it compiles independently againstmain. If #321 lands first, a minor rebase will update that path.Builds and compiles cleanly.
AI disclosure: Claude was consulted for reviewing the diff and drafting this description. All code changes were authored manually.