Skip to content

chore: move utils/epoch.zigepoch.zig#322

Open
markolazic01 wants to merge 1 commit intoChainSafe:mainfrom
markolazic01:chore/move-epoch-out-of-utils
Open

chore: move utils/epoch.zigepoch.zig#322
markolazic01 wants to merge 1 commit intoChainSafe:mainfrom
markolazic01:chore/move-epoch-out-of-utils

Conversation

@markolazic01
Copy link
Copy Markdown

chore: move utils/epoch.zigepoch.zig

Part of #169

Changes

  • Moved src/state_transition/utils/epoch.zig to src/state_transition/epoch.zig
  • Updated all import paths across block/, epoch/, slot/, cache/, signature_sets/, utils/, root.zig, and state_transition.zig
  • Updated internal imports within epoch.zig itself (EpochCache, getActivationExitChurnLimit, getConsolidationChurnLimit)
  • Removed the reference from utils_test_root.zig, consistent with how previous moves in this effort were handled
  • Fixed a double-slash typo in epoch_cache.zig: ../utils//epoch_shuffling.zig../utils/epoch_shuffling.zig

Note: this PR keeps the validator import in epoch.zig as ./utils/validator.zig so it compiles independently against main. If #321 lands first, a minor rebase will update that path.

Builds and compiles cleanly.

AI disclosure: Claude was consulted for reviewing the diff and drafting this description. All code changes were authored manually.

@markolazic01 markolazic01 requested a review from a team as a code owner April 21, 2026 19:56
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project structure by moving the epoch-related utility file to a more appropriate location within the state transition module. This change improves the logical organization of the codebase and requires updating numerous import statements throughout the repository to ensure continued compatibility and build success.

Highlights

  • File Relocation: Moved src/state_transition/utils/epoch.zig to src/state_transition/epoch.zig to better organize the codebase.
  • Import Updates: Updated all import paths across the project to reflect the new location of epoch.zig and fixed a double-slash typo in epoch_cache.zig.
  • Test Cleanup: Removed the reference to epoch.zig from utils_test_root.zig to maintain consistency with the new file structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving epoch.zig from the utils directory to the state_transition root, requiring import path updates across multiple files. The review feedback highlights two violations of the repository's 100-column line length limit in process_consolidation_request.zig and anchor_checkpoint.zig resulting from these import changes.

const isPubkeyKnown = electra_utils.isPubkeyKnown;
const switchToCompoundingValidator = electra_utils.switchToCompoundingValidator;
const computeConsolidationEpochAndUpdateChurn = @import("../utils/epoch.zig").computeConsolidationEpochAndUpdateChurn;
const computeConsolidationEpochAndUpdateChurn = @import("../epoch.zig").computeConsolidationEpochAndUpdateChurn;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line exceeds the 100-column limit (113 characters), which is a violation of the repository style guide. Grouping the import can help resolve this while maintaining clarity.

const epoch_utils = @import("../epoch.zig");
const computeConsolidationEpochAndUpdateChurn = epoch_utils.computeConsolidationEpochAndUpdateChurn;
References
  1. Hard limit all line lengths, without exception, to at most 100 columns. (link)

const c = @import("constants");
const ZERO_HASH = c.ZERO_HASH;
const computeCheckpointEpochAtStateSlot = @import("./epoch.zig").computeCheckpointEpochAtStateSlot;
const computeCheckpointEpochAtStateSlot = @import("../epoch.zig").computeCheckpointEpochAtStateSlot;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line exceeds the 100-column limit (101 characters). Following the repository style guide, all lines must be at most 100 columns. Consider grouping the import to reduce line length.

const epoch_utils = @import("../epoch.zig");
const computeCheckpointEpochAtStateSlot = epoch_utils.computeCheckpointEpochAtStateSlot;
References
  1. Hard limit all line lengths, without exception, to at most 100 columns. (link)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an unrelated change request as the repo generally does not follow this rule, I guess it should be formatted as a whole some time later.
Will leave as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant