-
Notifications
You must be signed in to change notification settings - Fork 12
chore: move utils/epoch.zig → epoch.zig
#322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ const AnyBeaconBlock = @import("fork_types").AnyBeaconBlock; | |
| const ForkTypes = @import("fork_types").ForkTypes; | ||
| const c = @import("constants"); | ||
| const ZERO_HASH = c.ZERO_HASH; | ||
| const computeCheckpointEpochAtStateSlot = @import("./epoch.zig").computeCheckpointEpochAtStateSlot; | ||
| const computeCheckpointEpochAtStateSlot = @import("../epoch.zig").computeCheckpointEpochAtStateSlot; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line exceeds the 100-column limit (101 characters). Following the repository style guide, all lines must be at most 100 columns. Consider grouping the import to reduce line length. References
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like an unrelated change request as the repo generally does not follow this rule, I guess it should be formatted as a whole some time later. |
||
|
|
||
| pub const AnchorCheckpoint = struct { | ||
| checkpoint: types.phase0.Checkpoint.Type, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line exceeds the 100-column limit (113 characters), which is a violation of the repository style guide. Grouping the import can help resolve this while maintaining clarity.
References