fix: bump discv5 to 11.0.4 #8365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @philknows, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a significant networking issue by updating a core dependency. The change ensures that the application can correctly handle dual-stack network configurations, preventing startup failures related to port binding.
Highlights
- Dependency Update: Bumps the @chainsafe/discv5 library from version 11.0.3 to 11.0.4. This update specifically addresses a critical bug where the application would fail to bind IPv4 and IPv6 ports simultaneously in dual-stack mode, leading to a "Timeout: Did not receive an init message from worker" error.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
nflaig
approved these changes
Sep 10, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the @chainsafe/discv5 dependency to version 11.0.4 to resolve a critical issue with dual-stack port binding. The change is straightforward and well-motivated. I've added suggestions to pin the dependency to this exact version in both package.json files. This is a recommended practice to ensure stability and prevent any potential regressions from future patch releases, especially when a specific version is known to contain an important fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8365 +/- ##
============================================
- Coverage 54.09% 54.08% -0.01%
============================================
Files 850 850
Lines 64193 64195 +2
Branches 4855 4852 -3
============================================
- Hits 34723 34722 -1
- Misses 29393 29396 +3
Partials 77 77 🚀 New features to boost your workflow:
|
philknows
added a commit
that referenced
this pull request
Sep 10, 2025
**Motivation** Users reported in the v1.34.0 release that changes in the release created an issue when ipv6 and ipv4 ports were the same: ``` ✖ Error: Timeout: Did not receive an init message from worker after 300000ms. Make sure the worker calls expose(). ``` **Description** This PR bumps discv5 from 11.0.3 to 11.0.4 which includes the fix to binding ipv4 and ipv6 on the same port in dual stack mode. See: ChainSafe/discv5#318
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Member
|
🎉 This PR is included in v1.34.1 🎉 |
Member
|
🎉 This PR is included in v1.35.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users reported in the v1.34.0 release that changes in the release created an issue when ipv6 and ipv4 ports were the same:
Description
This PR bumps discv5 from 11.0.3 to 11.0.4 which includes the fix to binding ipv4 and ipv6 on the same port in dual stack mode.
See: ChainSafe/discv5#318