Skip to content

Conversation

@Jaben
Copy link
Member

@Jaben Jaben commented Nov 11, 2025

Restored email receiving functionality that was broken between v7.5.1 and v7.6.1. Modified PapercutSmtpModule to fix SMTP server configuration.

Fixes #339

Summary by CodeRabbit

  • Chores
    • Improved SMTP module configuration flexibility by making IP allowlist configuration optional with automatic fallback to default settings, enhancing system robustness when explicit configuration is not provided.

Restored email receiving functionality that was broken between v7.5.1 and v7.6.1.
Modified PapercutSmtpModule to fix SMTP server configuration.

Fixes #339
@Jaben Jaben merged commit 764261f into develop Nov 11, 2025
7 of 8 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Modified the IPAllowedList dependency resolution in PapercutSmtpModule from mandatory to optional with a fallback default of IPAllowedList.AllowAll, enabling the SMTP module to function when this dependency is not explicitly registered.

Changes

Cohort / File(s) Summary
Dependency Injection Configuration
src/Papercut.Infrastructure.Smtp/PapercutSmtpModule.cs
Changed IPAllowedList retrieval from Resolve() to ResolveOptional() with fallback to IPAllowedList.AllowAll in IpAllowlistMailboxFilter factory setup

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-line change that makes a dependency optional with a sensible default
  • Localized modification addressing a dependency injection issue affecting email sending functionality
  • Verify that the AllowAll fallback is the intended default behavior when IPAllowedList is not registered

Poem

🐰 A gentle hop through DI's hall,
Where optional means no wall—
Let emails flow when dependencies stall,
With AllowAll's friendly call! 📧

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/339-fix-email-sending-regression

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c8d097 and 3efca03.

📒 Files selected for processing (1)
  • src/Papercut.Infrastructure.Smtp/PapercutSmtpModule.cs (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jaben Jaben deleted the feature/339-fix-email-sending-regression branch November 11, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email Sending not working

2 participants