feat: More password requirements (M2-10505) - #2036
Merged
Merged
Conversation
Match RegExp that @sricharan-varanasi for JavaScript.
{apps.authentication.services => apps.users}.password_validation
The max length check is not relevant for bcrypt because Python's implementation truncates input >72 bytes. It would also not be relevant if we migrate to Argon2id which handles long input without issue.
Match error messages in ChildMindInstitute/mindlogger-admin#2207.
Contributor
Author
|
Pushing this for review first. Still need to make a small update to the uppercase/lowercase logic to allow caseless Arabic or CJK characters. |
adeiji
reviewed
Apr 10, 2026
adeiji
left a comment
adeiji
left a comment
Contributor
There was a problem hiding this comment.
Didn't mean to approve, just wanted to leave a comment, so submitting another review.
4 tasks
sricharan-varanasi
previously requested changes
Apr 10, 2026
Previously an indirect dependency via fastapi-mail.
divbzero
dismissed
sricharan-varanasi’s stale review
April 10, 2026 20:42
Implemented requested change with commit 04c644f.
Contributor
Author
|
For future reference, alternatives to regex that I considered for counting grapheme clusters:
regex ended up being the natural choice because it’s mature, very widely used, actively maintained, and already an indirect dependency via fastapi-mail. |
1 task
divbzero
added a commit
that referenced
this pull request
Apr 13, 2026
…2038) 🔗 [Jira Ticket M2-10505](https://mindlogger.atlassian.net/browse/M2-10505) Changes include: - Validate caseless characters in passwords as both uppercase and lowercase. This is a follow-up to pull request #2036. After thinking through @jodybrookover’s comments, seems to make sense to allow caseless characters in passwords to validate as both uppercase and lowercase letters. There tend to be more caseless characters than uppercase or lowercase letters, and this matches the behavior already implemented on the frontend with: - ChildMindInstitute/mindlogger-admin#2207 - ChildMindInstitute/mindlogger-app-refactor#1089 - ChildMindInstitute/mindlogger-web-refactor#719
1 task
divbzero
added a commit
that referenced
this pull request
Apr 27, 2026
🔗 [Jira Ticket M2-10505](https://mindlogger.atlassian.net/browse/M2-10505) Changes include: - Reject passwords that contain standard emoji or regional indicators. This is a follow-up to pull requests #2036 and #2038 that brings backend password validation in line with what @adeiji implemented for emojis on the front end in: - ChildMindInstitute/mindlogger-admin#2207 - ChildMindInstitute/mindlogger-app-refactor#1089 - ChildMindInstitute/mindlogger-web-refactor#719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-10505
Changes include:
Related to: