Skip to content

fix: upgrade HCRC-lib to fix CMS page table figure styles#966

Merged
nikomakela merged 1 commit into
HCRC-191-org-scoped-hcrcfrom
LIIKUNTA-771-upgrade-fix-cms-styles
Jan 15, 2026
Merged

fix: upgrade HCRC-lib to fix CMS page table figure styles#966
nikomakela merged 1 commit into
HCRC-191-org-scoped-hcrcfrom
LIIKUNTA-771-upgrade-fix-cms-styles

Conversation

@nikomakela

@nikomakela nikomakela commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

LIIKUNTA-771.

Reference:
City-of-Helsinki/react-helsinki-headless-cms#235

Bases on #965, which is still unmerged and unapproved.

@sonarqubecloud

Copy link
Copy Markdown

@nikomakela nikomakela requested review from a team and karisal-anders January 14, 2026 10:42

@karisal-anders karisal-anders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, but as this PR doesn't seem to have run any environments where one could see this in action it is unknown how this looks in practice in liikunta/harrastukset/tapahtumat apps. So, caveat emptor!
Image

@karisal-anders

karisal-anders commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Screenshots from locally running this PR's sports app using product data as input:

  • image
  • image

In the latter screenshot I could access the out of view parts of the table with swiping. Tested only sports app.

@karisal-anders

Copy link
Copy Markdown
Contributor

Now this is waiting for review by @City-of-Helsinki/ratkaisutoimiston-backend and/or @City-of-Helsinki/ratkaisutoimiston-frontend

@nikomakela nikomakela merged commit 4fc3d9a into HCRC-191-org-scoped-hcrc Jan 15, 2026
9 checks passed
@nikomakela

Copy link
Copy Markdown
Contributor Author

oops.. this was merged after the branch were it was based, but it still never got merged to main branch. That commit is now manually cherry picked to main.

@charn charn deleted the LIIKUNTA-771-upgrade-fix-cms-styles branch July 8, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants