fix: tell sonar to skip two lines KEH-191#293
Merged
Conversation
Refs: KEH-191
|
LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr293-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedregistrations-pr293-ui.dev.hel.ninja 😆🎉🎉🎉 |
Refs: KEH-191
|
|
LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr293-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedregistrations-pr293-ui.dev.hel.ninja 😆🎉🎉🎉 |
mikkojamG
approved these changes
Apr 28, 2026
mikkojamG
left a comment
mikkojamG
left a comment
Contributor
There was a problem hiding this comment.
👍 With testUtils.tsx we could also consider excluding it from Sonar scanning entirely in sonar-project.properties. This is ok solution too 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: KEH-191
Description ✨
Sonar complains about math random being used. But it is used only in unit tests.
Decided to skip sonar on those lines.
Edit.
Also fix a unit test that is failing for some reason.
Closes 🙅♀️
KEH-191: