Skip to content

fix: tell sonar to skip two lines KEH-191 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Riippi merged 2 commits into from
Apr 28, 2026
Merged

fix: tell sonar to skip two lines KEH-191 #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acff769
fix: tell sonar to skip two lines
Riippi Apr 27, 2026
e0e2e81
fix: fix unit test
Riippi Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/domain/singups/__mocks__/testUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ export const shouldExportSignupsAsExcel = async (
// Mock document.createElement which is needed by downloadBlob. RenderComponent needs
// createElement so do this after rendering components to avoid errors
const createElement = document.createElement;
document.createElement = vi.fn().mockImplementation(() => link);
document.createElement = vi
.fn()
.mockImplementation((tagName: string, ...args: any[]) => {
if (tagName === 'a') return link;
return createElement.call(document, tagName, ...args);
});

await user.click(exportAsExcelButton);

Expand Down
4 changes: 2 additions & 2 deletions src/utils/testUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ const actWait = (amount?: number): Promise<void> => act(() => wait(amount));

const mockNumberString = (size: number): string =>
[...Array(size)]
.map(() => Math.floor(Math.random() * 10).toString())
.map(() => Math.floor(Math.random() * 10).toString()) // NOSONAR
.join('');

const mockString = (size: number): string =>
[...Array(size)].map(() => Math.random().toString(36)[2]).join('');
[...Array(size)].map(() => Math.random().toString(36)[2]).join(''); // NOSONAR

const loadingSpinnerIsNotInDocument = async (timeout = 1000): Promise<void> =>
waitFor(
Expand Down
Loading