SHPPWS-103: add feedback survey-link to email templates by Nukasev · Pull Request #637 · City-of-Helsinki/parking-permits

Nukasev · 2026-01-27T12:25:12Z

Description

add feedback survey-link to email templates

How Has This Been Tested?

permit_ended-email has been tested locally via mailpit, this should cover all cases as all the relevant emails use the same (or similiar) base template where the change has been made.

azure-pipelines · 2026-01-27T12:31:54Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-27T13:13:25Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-27T13:26:59Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

mhieta

Line numbers in translations makes them too verbose and also gives no actual real value, because you can always search the translation and get their location. So better not use them at all. Try running commands to remove them:

python manage.py makemessages -l fi --no-location
python manage.py makemessages -l sv --no-location

Also fuzzy-translations should be updated to match latest desired translation value and # fuzzy removed completely from them.

Empty "" -translations should be updated also to match the actual desired translation value.

azure-pipelines · 2026-01-30T08:47:55Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

azure-pipelines · 2026-01-30T09:30:50Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

Nukasev · 2026-01-30T09:33:14Z

Fixed finnish translation file as requested by @mhieta. @Niilis do you have any suggestions for the missing swedish translations?

Niilis · 2026-02-05T15:08:10Z

Fixed finnish translation file as requested by @mhieta. @Niilis do you have any suggestions for the missing swedish translations?

msgid "Permit count"
msgstr "Antal tillstånd"

msgid "Date"
msgstr "Datum"

msgid "Parking zone name"
msgstr "Namn på parkeringsområde"

msgid "Parking zone description"
msgstr "Deskription för parkeringsområde"

msgid "Parking zone description sv"
msgstr "Deskription för parkeringsområde (sv)"

msgid "Low-emission criteria"
msgstr "Kriterier för lågemission fordon"

msgid "Primary vehicle"
msgstr "Primär fordon"

msgid "Permit count snapshot"
msgstr "Ögonblicksbild av antal tilstånd"

msgid "Permit count snapshots"
msgstr "Ögonblicksbilder av antal tillstånd"

msgid "Customer does not have a valid driving licence for this vehicle"
msgstr "Kunden har inte ett giltigt körkort för detta fordon"

msgid "This person has a non-disclosure statement"
msgstr "Den här personen har spärr mot utlämnande av uppgifter"

msgid "Source: Transport register, Traficom"
msgstr "Källa: Trafik- och transportregistret, Traficom"

msgid "What do you think about this service?"
msgstr "Vad tycker du om den här tjänsten?"

msgid "Give us your feedback!"
msgstr "Ge oss din feedback!"

msgid "incl. VAT"
msgstr "inkl. MOMS"

Here are all of the lines that were changed in the Swedish translation translated. I might have translated already translated strings. I tried to align these with the already translated strings that are correct.

azure-pipelines · 2026-02-06T11:51:17Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

Nukasev · 2026-02-06T11:52:47Z

Updated the missing Swedish translations, re-marking the PR as ready for review.

azure-pipelines · 2026-02-06T12:00:11Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

locale/sv/LC_MESSAGES/django.po

azure-pipelines · 2026-02-09T07:06:32Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

Niilis

The Swedish translations are good to go now. Not sure about the other changes but with a quick glance I did not find anything to comment about.

refs SHPPWS-103

Reduce code duplication by splitting the base email-templates into reusable snippets. refs SHPPWS-103

sonarqubecloud · 2026-02-10T08:49:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

azure-pipelines · 2026-02-10T08:57:27Z

PYSAKOINNINVERKKOKAUPPA-BACKEND branch is deployed to platta: https://pysakoinninverkkokauppa-backend-pr637.dev.hel.ninja 🚀🚀🚀

mhieta

LGTM! 👍

Nukasev requested a review from mhieta January 27, 2026 12:25

Nukasev marked this pull request as draft January 27, 2026 12:47

Nukasev marked this pull request as ready for review January 27, 2026 13:14

mhieta requested changes Jan 29, 2026

View reviewed changes

Nukasev marked this pull request as draft January 30, 2026 08:40

Nukasev force-pushed the SHPPWS-103/add-feedback-survey-link-to-emails branch from 7260f93 to c1518ad Compare January 30, 2026 08:41

Nukasev force-pushed the SHPPWS-103/add-feedback-survey-link-to-emails branch 2 times, most recently from 276c83f to 592f562 Compare January 30, 2026 09:23

Nukasev requested a review from Niilis January 30, 2026 09:33

Nukasev force-pushed the SHPPWS-103/add-feedback-survey-link-to-emails branch 2 times, most recently from 5ad377e to 2eb7f6d Compare February 6, 2026 11:44

Nukasev marked this pull request as ready for review February 6, 2026 11:53

Niilis requested changes Feb 6, 2026

View reviewed changes

locale/sv/LC_MESSAGES/django.po Outdated Show resolved Hide resolved

Nukasev force-pushed the SHPPWS-103/add-feedback-survey-link-to-emails branch from 2eb7f6d to d70e7b8 Compare February 9, 2026 06:59

Nukasev changed the title ~~SHPPWS-503: add feedback survey-link to email templates~~ SHPPWS-103: add feedback survey-link to email templates Feb 9, 2026

Niilis previously approved these changes Feb 9, 2026

View reviewed changes

Nukasev added 3 commits February 10, 2026 10:43

feat: add feedback survey-link to email templates

0402023

refs SHPPWS-103

chore: split base email-templates

5d9ee53

Reduce code duplication by splitting the base email-templates into reusable snippets. refs SHPPWS-103

fix: update translations

8a01adb

Nukasev dismissed Niilis’s stale review via 8a01adb February 10, 2026 08:46

Nukasev force-pushed the SHPPWS-103/add-feedback-survey-link-to-emails branch from d70e7b8 to 8a01adb Compare February 10, 2026 08:46

mhieta approved these changes Feb 10, 2026

View reviewed changes

Nukasev merged commit 0da6ddb into main Feb 10, 2026
24 checks passed

Nukasev deleted the SHPPWS-103/add-feedback-survey-link-to-emails branch February 10, 2026 12:02

Conversation

Nukasev commented Jan 27, 2026

Description

How Has This Been Tested?

Uh oh!

azure-pipelines bot commented Jan 27, 2026

Uh oh!

azure-pipelines bot commented Jan 27, 2026

Uh oh!

azure-pipelines bot commented Jan 27, 2026

Uh oh!

mhieta left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Jan 30, 2026

Uh oh!

azure-pipelines bot commented Jan 30, 2026

Uh oh!

Nukasev commented Jan 30, 2026

Uh oh!

Niilis commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

Nukasev commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

Uh oh!

azure-pipelines bot commented Feb 9, 2026

Uh oh!

Niilis left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 10, 2026

Quality Gate passed

Uh oh!

azure-pipelines bot commented Feb 10, 2026

Uh oh!

mhieta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Niilis commented Feb 5, 2026 •

edited

Loading