Skip to content

Fix bathroom window in home improvement store - #88480

Open
Snigdha-new wants to merge 2 commits into
CleverRaven:masterfrom
Snigdha-new:fix-home-improvement-bathroom-window
Open

Fix bathroom window in home improvement store#88480
Snigdha-new wants to merge 2 commits into
CleverRaven:masterfrom
Snigdha-new:fix-home-improvement-bathroom-window

Conversation

@Snigdha-new

@Snigdha-new Snigdha-new commented Aug 31, 2026

Copy link
Copy Markdown

Summary

Content "Fixed an incorrect bathroom window in the home improvement store map layout."

Purpose of change

The home improvement store map had a window next to the bathroom that allowed visibility from outside.

Describe the solution

Replaced the incorrect window tile with a wall tile in data/json/mapgen/homeimprovement.json.

Describe alternatives you've considered

None.

Testing

Validated the JSON data successfully; all 6,632 JSON files passed validation.

Additional context

Fixes #88412

@github-actions github-actions Bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 31, 2026
@kuutekitty

Copy link
Copy Markdown
Contributor

for the summary, category should be one of
Features, Content, Interface, Mods, Balance, Bugfixes, Performance, Infrastructure, Build, I18N
in "" you want a brief description.
you can also just omit it if you don't want a changelog entry and write None

@github-actions github-actions Bot added <Bugfix> This is a fix for a bug (or closes open issue) Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Sep 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @jbytheway


config.name = 'clang-tidy-cata'
config.test_format = lit.formats.ShTest(True)
config.test_format = lit.formats.ShTest(False)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an intentional change? if so, it should be moved to separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is home improvement store bathroom window incorrect?

3 participants