Skip to content

obsolete small_repairkit and large_repairkit - #88520

Draft
kuutekitty wants to merge 1 commit into
CleverRaven:masterfrom
kuutekitty:gun-kits
Draft

obsolete small_repairkit and large_repairkit#88520
kuutekitty wants to merge 1 commit into
CleverRaven:masterfrom
kuutekitty:gun-kits

Conversation

@kuutekitty

@kuutekitty kuutekitty commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

their spawns with guns_toolbox

Summary

Content "obsolete gunsmith and firearm repairkits"

Purpose of change

they don't make sense

Describe the solution

remove all mentions of them besides their item definition, replace their spawns with guns_toolbox that has sane tools for repairing or working on guns

Describe alternatives you've considered

Testing

tbd

Additional context

will rely on #88526 to redo many of the modified gunmod recipes and make them sane (also able to use things other than those repairkits)

@github-actions github-actions Bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 4, 2026
@Zerdocriil

Copy link
Copy Markdown
Contributor

You can not repair damaged guns without firearm repairkits
So firearm repairkits should be stayed or other method gun repairing implemented

@kuutekitty

kuutekitty commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

gun repair is questionable at best (depends what you're repairing, it should be entirely replaced with faults) but this pr will likely attempt to add another tool, but leaving gun repair broken isn't that much of a problem due to how easy it is to find more guns, guns rarely get damaged, and they're almost always found in perfect condition.

though breaking a feature before it is replaced is rarely an ideal situation and we'll hopefully avoid it (Since we doubt adding more faults tied to specific events like smashing with a gun would be a json only change and that should be part of entirely removing durability from guns and replacing it with faults)

the bigger problem is certain mods have INSTALL_DIFFICULT and we either need to make it so you need certain tools for each gunmod and remove install difficult, remove it without replacing it or replace the repairkits INSTALL_DIFFICULT needs with a group of items if possible

@Bone-blood-moss

Copy link
Copy Markdown

Why This is like Obsoleting Sewing kits because we have needles.

@kuutekitty

kuutekitty commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

gun repair kits don't make sense. besides the tools you need to make one not making sense, gun "repair" (as in literally repairing the durability) doesn't make sense either. faults could probably entirely replace gun repair. and when faults do replace gun repair the fault will just specify what tools and/or qualities it needs to be fixed (if it is indeed fixeable).

an actual "kit" would just be a bunch of tools in a toolbox or other container, if we can just put said tools in said container, why would we need a seperate item as well to represent a bunch of tools in a container?

we would also ask what one would even have in a sewing kit (certain scissors to cut fabric and multiple types of needles likely) and if it should be a different item at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants