obsolete small_repairkit and large_repairkit - #88520
Conversation
their spawns with guns_toolbox
|
You can not repair damaged guns without firearm repairkits |
|
gun repair is questionable at best (depends what you're repairing, it should be entirely replaced with faults) but this pr will likely attempt to add another tool, but leaving gun repair broken isn't that much of a problem due to how easy it is to find more guns, guns rarely get damaged, and they're almost always found in perfect condition. though breaking a feature before it is replaced is rarely an ideal situation and we'll hopefully avoid it (Since we doubt adding more faults tied to specific events like smashing with a gun would be a json only change and that should be part of entirely removing durability from guns and replacing it with faults) the bigger problem is certain mods have INSTALL_DIFFICULT and we either need to make it so you need certain tools for each gunmod and remove install difficult, remove it without replacing it or replace the repairkits INSTALL_DIFFICULT needs with a group of items if possible |
|
Why This is like Obsoleting Sewing kits because we have needles. |
|
gun repair kits don't make sense. besides the tools you need to make one not making sense, gun "repair" (as in literally repairing the durability) doesn't make sense either. faults could probably entirely replace gun repair. and when faults do replace gun repair the fault will just specify what tools and/or qualities it needs to be fixed (if it is indeed fixeable). an actual "kit" would just be a bunch of tools in a toolbox or other container, if we can just put said tools in said container, why would we need a seperate item as well to represent a bunch of tools in a container? we would also ask what one would even have in a sewing kit (certain scissors to cut fabric and multiple types of needles likely) and if it should be a different item at all |
their spawns with guns_toolbox
Summary
Content "obsolete gunsmith and firearm repairkits"
Purpose of change
they don't make sense
Describe the solution
remove all mentions of them besides their item definition, replace their spawns with guns_toolbox that has sane tools for repairing or working on guns
Describe alternatives you've considered
Testing
tbd
Additional context
will rely on #88526 to redo many of the modified gunmod recipes and make them sane (also able to use things other than those repairkits)