Extract character creation stat prompts - #88521
Open
eugene-lesnov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I18N "Extract character creation stat and skill input prompts"
Purpose of change
Some prompts in character creation still show up in English without translation:
Set new strength (between 4 and 20):The stat and skill input prompts are not passed through gettext, and the stat name in the stat prompt is not translated either.
Describe the solution
Make the stat and skill input prompts translatable.
For stats, also pass the full stat name through gettext.
Skill names are already translated by
skill_queried->name(), so nothing else is needed there.Describe alternatives you've considered
None
Testing
Ran
lang/update_pot.shsuccessfully.Verified that both prompts are present in the generated translation template:
Set new %s (between %d and %d):Set new %s skill level (between %d and %d):Compiled
src/newcharacter.cpp.Additional context
None