Skip to content

Extract character creation stat prompts - #88521

Open
eugene-lesnov wants to merge 1 commit into
CleverRaven:masterfrom
eugene-lesnov:extract-character-creation-stat-prompts
Open

Extract character creation stat prompts#88521
eugene-lesnov wants to merge 1 commit into
CleverRaven:masterfrom
eugene-lesnov:extract-character-creation-stat-prompts

Conversation

@eugene-lesnov

@eugene-lesnov eugene-lesnov commented Sep 4, 2026

Copy link
Copy Markdown

Summary

I18N "Extract character creation stat and skill input prompts"

Purpose of change

Some prompts in character creation still show up in English without translation:
Set new strength (between 4 and 20):

The stat and skill input prompts are not passed through gettext, and the stat name in the stat prompt is not translated either.

Describe the solution

Make the stat and skill input prompts translatable.

For stats, also pass the full stat name through gettext.
Skill names are already translated by skill_queried->name(), so nothing else is needed there.

Describe alternatives you've considered

None

Testing

Ran lang/update_pot.sh successfully.

Verified that both prompts are present in the generated translation template:

  • Set new %s (between %d and %d):
  • Set new %s skill level (between %d and %d):

Compiled src/newcharacter.cpp.

Additional context

None

@github-actions github-actions Bot added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Translation I18n astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world json-styled JSON lint passed, label assigned by github actions Translation I18n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant