Fix O(N^2) performance degradation in form_from_map - #88527
Open
IcarusOfTroy wants to merge 4 commits into
Open
Conversation
IcarusOfTroy
marked this pull request as ready for review
September 4, 2026 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance "Fix O(N^2) performance degradation in form_from_map"
Purpose of change
Fixes #88525.
The game would hang or severely degrade in performance when there were a lot of items around, particularly when opening menus that list items such as crafting or vehicle inspection.
Describe the solution
Hoists the bulk item batching out of the per-tile loop in
inventory::form_from_map. Previously,add_items_bulkwas called once for every tile containing more than one item, causing severe slowdowns when surrounded by many items, as it rebuilds an index of the entire accumulated inventory each time. Now, it gathers all items across all tiles into a single batch and callsadd_items_bulkexactly once at the end of the function.Describe alternatives you've considered
N/A
Testing
Compiled and checked that
form_from_mapcorrectly gathers all items into the single bulk batch, restoring expected performance and avoiding the O(N^2) stack sweeps.Added a new unit test
tests/inventory_test.cppcontaininginventory_form_from_map_bulk_batching. This programmatic test proves thatform_from_mapproperly pools items from multiple coordinates into a single bulk batch with correct totals, guarding against future regressions in the inventory loading pipeline.Additional context
None