build(android): generate AAR dependencies from sdl3Aars list - #88534
Open
dwvwvvwvwb wants to merge 1 commit into
Open
build(android): generate AAR dependencies from sdl3Aars list#88534dwvwvvwvwb wants to merge 1 commit into
dwvwvvwvwb wants to merge 1 commit into
Conversation
Replaced hardcoded SDL AAR dependencies with dynamic loading from sdl3Aars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build "Dynamically include SDL AARs from sdl3Aars list"
Purpose of change
The dependencies block currently hardcodes exact filenames of SDL AARs (e.g.
SDL3-3.4.10.aar). This forces manual updates every time we upgrade SDL versions and creates inconsistency with thesdl3Aarslist used for downloading.This change makes the dependency list automatically reflect the versions defined in
sdl3Aars, improving maintainability without altering any functionality.Describe the solution
Replace the explicit
implementation files(...)list with a loop oversdl3Aarsin thedependenciesblock. Each entry generatesimplementation files("libs/${entry.name}-${entry.version}.aar").No version numbers are changed – the existing
sdl3Aarsremains untouched.Describe alternatives you've considered
fileTree(dir: 'libs', include: ['*.aar'])– simpler but less explicit; could accidentally include unrelated AARs. Looping oversdl3Aarsis safer because it only includes what we explicitly want.Testing
./gradlew cleanto ensure a fresh state../gradlew assembleRelease– build completed successfully.Additional context
None – this is a pure build script refactor with zero impact on the game's code or behavior.