use TripolarGrid, ConservativeRegridding by juliasloan25 · Pull Request #1679 · CliMA/ClimaCoupler.jl

juliasloan25 · 2026-01-22T01:07:38Z

Purpose

New version of #1593 to use ConservativeRegridding with the TripolarGrid

Content

extend Interfacer.remap! for Oceananigans fields using CR.jl
remove interpolate! calls
add a function construct_remappers to make the remapper object and allocate scratch space
switch to TripolarGrid + JLD2 diagnostics

I have read and checked the items on the review checklist.

…limaCoupler.jl into js/tripolar-conservative-jan2026

This reverts commit 67723ff.

This reverts commit 1767141.

This reverts commit 494df64.

juliasloan25 · 2026-02-05T17:26:00Z

-    tracer_advection = OC.WENO(order = 5)
-    horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11)
+        # Use Float32 for the vertical mixing parameters to avoid parameter memory limits
+        vertical_mixing = OC.CATKEVerticalDiffusivity(Float32)


try removing this

simone-silvestri · 2026-02-05T17:26:59Z

+        @info "Using simpler ocean setup; to be used for software testing only."
+        free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70)
+        momentum_advection = OC.VectorInvariant()
+        tracer_advection = OC.WENO(order = 5)
+        horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11)

-    # Create ocean simulation
-    free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70)
-    momentum_advection = OC.VectorInvariant()
-    tracer_advection = OC.WENO(order = 5)
-    horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11)
+        # Use Float32 for the vertical mixing parameters to avoid parameter memory limits
+        vertical_mixing = OC.CATKEVerticalDiffusivity(Float32)


Suggested change

@info "Using simpler ocean setup; to be used for software testing only."

free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70)

momentum_advection = OC.VectorInvariant()

tracer_advection = OC.WENO(order = 5)

horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11)

# Create ocean simulation

free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70)

momentum_advection = OC.VectorInvariant()

tracer_advection = OC.WENO(order = 5)

horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11)

# Use Float32 for the vertical mixing parameters to avoid parameter memory limits

vertical_mixing = OC.CATKEVerticalDiffusivity(Float32)

@info "Using simpler ocean setup; to be used for software testing only."

free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70)

momentum_advection = OC.VectorInvariant()

tracer_advection = OC.WENO(order = 5)

horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11)

# Use Float32 for the vertical mixing parameters to avoid parameter memory limits

vertical_mixing = OC.ConvectiveAdjustmentVerticalDiffusivity(background_κz = 1e-5, convective_κz = 0.1, background_νz = 1e-4, convective_νz = 0.1)

juliasloan25 · 2026-02-11T18:16:01Z

+    Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz, sim.remapping) # zonal momentum flux
+    Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz, sim.remapping) # meridional momentum flux


bug (fixed in new branch)

Suggested change

Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz, sim.remapping) # zonal momentum flux

Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz, sim.remapping) # meridional momentum flux

Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz_uv, sim.remapping) # zonal momentum flux

Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz_uv, sim.remapping) # meridional momentum flux

juliasloan25 · 2026-02-11T18:27:23Z

+    Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz, sim.remapping) # zonal momentum flux
+    Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz, sim.remapping) # meridional momentum flux


bug (fixed in new branch)

Suggested change

Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz, sim.remapping) # zonal momentum flux

Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz, sim.remapping) # meridional momentum flux

Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz_uv, sim.remapping) # zonal momentum flux

Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz_uv, sim.remapping) # meridional momentum flux

juliasloan25 · 2026-03-09T16:49:30Z

closing in favor of #1724

juliasloan25 added 2 commits January 21, 2026 16:58

use ConservativeRegridding

ed26eb8

use TripolarGrid [skip ci]

26815d5

simone-silvestri reviewed Jan 22, 2026

View reviewed changes

Comment thread experiments/ClimaEarth/components/ocean/remapping.jl Outdated

use TripolarGrid [skip ci]

c4d1688

juliasloan25 force-pushed the js/tripolar-conservative-jan2026 branch from 26815d5 to c4d1688 Compare January 22, 2026 18:48

simone-silvestri added 2 commits January 22, 2026 21:17

Merge branch 'js/tripolar-conservative-jan2026' of github.com:CliMA/C…

70c7164

…limaCoupler.jl into js/tripolar-conservative-jan2026

new ocean setup

6dd5577

juliasloan25 force-pushed the js/tripolar-conservative-jan2026 branch 2 times, most recently from 0135836 to b1db80e Compare January 27, 2026 18:44

juliasloan25 and others added 7 commits January 27, 2026 16:49

use ConservativeRegridding

a4c9fbf

use TripolarGrid [skip ci]

a9f117d

new ocean setup

306f0e2

use CR#main

c228a8c

use higher elem order in CMIP

f05866d

fix julia 1.10 manifest; oceananigans typo

31bf61c

use Float64 for CMIPs

accc24a

juliasloan25 force-pushed the js/tripolar-conservative-jan2026 branch from 3d752c0 to accc24a Compare January 28, 2026 00:52

juliasloan25 commented Jan 28, 2026

View reviewed changes

Comment thread experiments/ClimaEarth/components/ocean/oceananigans.jl

juliasloan25 commented Jan 28, 2026

View reviewed changes

Comment thread experiments/ClimaEarth/components/ocean/oceananigans.jl

juliasloan25 and others added 2 commits January 28, 2026 16:54

fix rebase; use Adapt for regridder [skip ci]

ef773b9

Merge branch 'js/tripolar-conservative-jan2026' of github.com:CliMA/C…

8516b9d

…limaCoupler.jl into js/tripolar-conservative-jan2026

simone-silvestri reviewed Jan 29, 2026

View reviewed changes

Comment thread experiments/ClimaEarth/components/ocean/oceananigans.jl Outdated

Apply suggestion from @simone-silvestri

410567b

simone-silvestri reviewed Jan 29, 2026

View reviewed changes

Comment thread experiments/ClimaEarth/components/ocean/oceananigans.jl

simone-silvestri and others added 6 commits January 29, 2026 18:38

Apply suggestion from @simone-silvestri

2561ffb

Fix indentation for remapper_oc_to_cc assignment

759a890

remove ocean restoring

07cc1e5

add simpler Oceananigans model option

d8c7cd6

use Int8 for OffsetArray indexing

67723ff

fixes

ebfc122

juliasloan25 commented Jan 29, 2026

View reviewed changes

Comment thread experiments/ClimaEarth/components/ocean/oceananigans.jl

juliasloan25 added 5 commits January 29, 2026 13:37

get ocean_simulation from CO

9f0a285

fix input test

7094cd2

Revert "use Int8 for OffsetArray indexing"

5a5fa15

This reverts commit 67723ff.

try simple ocean for regular CI CMIPs

769dfda

use ocean setup from main for simple ocean

e495d4f

juliasloan25 force-pushed the js/tripolar-conservative-jan2026 branch from 6ba52ad to e495d4f Compare January 30, 2026 00:43

juliasloan25 added 5 commits February 4, 2026 09:44

use latest 8 bit integer fix

1767141

use Int8 OffsetArrays fork

494df64

Revert "use latest 8 bit integer fix"

eb96ab8

This reverts commit 1767141.

Revert "use Int8 OffsetArrays fork"

c510950

This reverts commit 494df64.

try running CMIP on non-P100 GPUs (without Int8 fix)

9ecd8ee

juliasloan25 force-pushed the js/tripolar-conservative-jan2026 branch from 520376c to 9ecd8ee Compare February 5, 2026 00:25

run CMIP on v100s

25f0948

juliasloan25 commented Feb 5, 2026

View reviewed changes

simone-silvestri reviewed Feb 5, 2026

View reviewed changes

juliasloan25 added 5 commits February 5, 2026 10:47

make ocean setup even simpler; run on P100

c8ea286

put value_per_element array on GPU

882893b

dispatch on SeaIceSim for get_field

14480d0

use working ConservativeRegridding branch

8f7a42e

swap ocean/sea ice include order

91a4c96

juliasloan25 mentioned this pull request Feb 6, 2026

add simple ocean option and use Float32 for CMIP in CI #1715

Merged

5 tasks

juliasloan25 commented Feb 11, 2026

View reviewed changes

juliasloan25 mentioned this pull request Feb 11, 2026

tripolar + conservative - updated in ext #1724

Open

6 tasks

Add ConservativeRegridding dependency to Project.toml

76469eb

juliasloan25 closed this Mar 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use TripolarGrid, ConservativeRegridding#1679

use TripolarGrid, ConservativeRegridding#1679
juliasloan25 wants to merge 38 commits intomainfrom
js/tripolar-conservative-jan2026

juliasloan25 commented Jan 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliasloan25 Feb 5, 2026

Uh oh!

simone-silvestri Feb 5, 2026

Uh oh!

juliasloan25 Feb 11, 2026

Uh oh!

juliasloan25 Feb 11, 2026

Uh oh!

juliasloan25 commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		Interfacer.remap!(sim.remapping.scratch_field_oc1, F_turb_ρτxz, sim.remapping) # zonal momentum flux
		Interfacer.remap!(sim.remapping.scratch_field_oc2, F_turb_ρτyz, sim.remapping) # meridional momentum flux

Conversation

juliasloan25 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Content

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliasloan25 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

simone-silvestri Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

juliasloan25 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

juliasloan25 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

juliasloan25 commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

juliasloan25 commented Jan 22, 2026 •

edited

Loading