tripolar + conservative - updated in ext#1724
Conversation
21fc7d6 to
520d18c
Compare
| minimum_depth = 30, | ||
| interpolation_passes = 20, | ||
| minimum_depth = 20, | ||
| interpolation_passes = 2, |
There was a problem hiding this comment.
change to 25 after debugging
| To regrid from Oceananigans to ClimaCore, use `CR.regrid!(dest_vector, remapper_oc_to_cc, src_vector)`. | ||
| To regrid from ClimaCore to Oceananigans, use `CR.regrid!(dest_vector, transpose(remapper_oc_to_cc), src_vector)`. | ||
| """ | ||
| function construct_remappers(grid_oc, boundary_space) |
There was a problem hiding this comment.
move to remapping.jl
|
We can't use Float32 as the simulation float type when we use ConservativeRegridding. Even if we set it correctly to Float32 for the ocean grid and boundary space, there's a mismatch in source/dest manifolds because of the way GO.Spherical is called. Here for Oceananigans and here for ClimaCore We need the radius for the Oceananigans grid to agree with Error |
We can use 0.104.5 that should solve this issue |
| @@ -73,46 +49,35 @@ function OceananigansSimulation( | |||
| extra_kwargs..., | |||
| ) where {FT} | |||
There was a problem hiding this comment.
change substeps = 150 in the free surface constructor
80b3bb9 to
7f7f3e0
Compare
| Interfacer.remap!(target_field, source_field) | ||
|
|
||
| # Extend Interfacer.get_field to allow automatic remapping to the target space | ||
| function Interfacer.get_field!( |
There was a problem hiding this comment.
move these to a file that's included later so we can keep the Simulation struct definitions in the corresponding files
688245e to
767ccf6
Compare
d173c98 to
e2a731a
Compare
|
we should try removing sea ice dynamics while debugging: sea_ice_simulation(grid, ocean; dynamics=nothing) |
Purpose
Yet another version of #1679. I split that PR up into #1715 and this one since it was getting big.
To do
Content
Interfacer.remap!for Oceananigans fields using CR.jlinterpolate!callsconstruct_remappersto make the remapper object and allocate scratch space