Revert "fix: handle NotAllowedError from audio.play()"#23
Merged
Just-Insane merged 1 commit intoJun 3, 2026
Merged
Conversation
Just-Insane
deleted the
revert-22-seer/fix/handle-audio-play-notallowederror
branch
|
There was a problem hiding this comment.
Pull request overview
This PR reverts a prior change (#22) that handled HTMLAudioElement.play() rejections for notification sounds, returning the behavior to calling play() without handling promise failures.
Changes:
- Removed
.catch(() => {})handling from invite notification sound playback. - Removed
.catch(() => {})handling from message notification sound playback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
198
to
202
| const playSound = useCallback(() => { | ||
| const audioElement = audioRef.current; | ||
| audioElement?.play().catch(() => {}); | ||
| audioElement?.play(); | ||
| clearMediaSessionQuickly(); | ||
| }, []); |
Comment on lines
272
to
276
| const playSound = useCallback(() => { | ||
| const audioElement = audioRef.current; | ||
| audioElement?.play().catch(() => {}); | ||
| audioElement?.play(); | ||
| clearMediaSessionQuickly(); | ||
| }, []); |
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-23-sable.justin-tech.workers.dev | 89376ec | pr-23 |
Wed, 03 Jun 2026 13:11:37 GMT |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #22