chore: bump actions/upload-artifact from 4.3.3 to 7.0.1 in the github-actions group across 1 directory#289
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fa9ebef48
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: Upload snapshot artifact for debugging | ||
| if: always() && hashFiles('.artifacts/sentry-snapshots/**/*.png') != '' | ||
| uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 |
There was a problem hiding this comment.
Include hidden snapshot artifacts
When this workflow produces screenshots, they are written under .artifacts/sentry-snapshots, and actions/upload-artifact@v7 defaults include-hidden-files to false while treating files inside dot-prefixed directories as hidden. This means the debugging upload step will no longer attach the generated PNGs, despite the preceding hashFiles condition being true. Add include-hidden-files: true here or move the snapshot output outside .artifacts.
Useful? React with 👍 / 👎.
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/vitestThe overall coverage remains at 27%, unchanged from the branch. Updated |
5fa9ebe to
446859c
Compare
Bumps the github-actions group with 1 update in the / directory: [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/upload-artifact` from 4.3.3 to 7.0.1 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.3.3...043fb46) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
446859c to
8fe7f9c
Compare
|
Looks like actions/upload-artifact is updatable in another way, so this is no longer needed. |
Pull request was closed
Bumps the github-actions group with 1 update in the / directory: actions/upload-artifact.
Updates
actions/upload-artifactfrom 4.3.3 to 7.0.1Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
043fb46Merge pull request #797 from actions/yacaovsnc/update-dependency634250cInclude changes in typespec/ts-http-runtime 0.3.5e454baaReadme: bump all the example versions to v7 (#796)74fad66Update the readme with direct upload details (#795)bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in README