Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/live-matrix-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- name: Upload Playwright report
if: failure()
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: live-matrix-playwright-report
path: playwright-report
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/playwright-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ jobs:

- name: Upload Playwright report
if: failure()
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: playwright-report
path: playwright-report
if-no-files-found: ignore

- name: Upload Playwright results
if: failure()
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: playwright-test-results
path: test-results
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sentry-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:

- name: Upload snapshot artifact for debugging
if: always() && hashFiles('.artifacts/sentry-snapshots/**/*.png') != ''
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include hidden snapshot artifacts

When this workflow produces screenshots, they are written under .artifacts/sentry-snapshots, and actions/upload-artifact@v7 defaults include-hidden-files to false while treating files inside dot-prefixed directories as hidden. This means the debugging upload step will no longer attach the generated PNGs, despite the preceding hashFiles condition being true. Add include-hidden-files: true here or move the snapshot output outside .artifacts.

Useful? React with 👍 / 👎.

with:
name: sentry-snapshots-pr-${{ github.event.pull_request.number }}
path: .artifacts/sentry-snapshots
Expand Down
Loading