Dev: Add error log when cluster services fail to start

[liangxin1300]

Problem 1

crmsh will show success logs when success to start:

# crm cluster start --all
INFO: Starting pacemaker.service on alp-1, alp-2
INFO: The cluster stack started on alp-1
INFO: The cluster stack started on alp-2

But will show nothing when fail to start:

# crm cluster start --all
INFO: Starting pacemaker.service on alp-1, alp-2

Solution

# crm cluster start --all
INFO: Starting pacemaker.service on alp-1, alp-2
ERROR: The cluster stack failed to start on alp-1
INFO: The cluster stack started on alp-2

Promblem 2

When the fatal error leads to start pacemaker failing, the bootstrap process will wait for a long time:

# crm cluster init -y
...
INFO: Starting pacemaker.service on alp-1
INFO: BEGIN Waiting for cluster
.............................................................                                                                                                                                      
ERROR: FAIL Waiting for cluster
ERROR: cluster.init: Time out waiting for cluster.

Solution

check the return code and quit quickly

# crm cluster init -y
...
INFO: Starting pacemaker.service on alp-1
ERROR: cluster.init: Failed to start cluster services

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (87655e0) to head (151788c).

Files with missing lines	Patch %	Lines
crmsh/bootstrap.py	50.00%	1 Missing ⚠️
crmsh/ui_cluster.py	91.66%	1 Missing ⚠️

Additional details and impacted files

Flag	Coverage Δ
integration	53.61% <62.50%> (-0.01%)	⬇️
unit	53.08% <81.25%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
crmsh/service_manager.py	98.07% <100.00%> (+0.03%)	⬆️
crmsh/bootstrap.py	88.04% <50.00%> (-0.06%)	⬇️
crmsh/ui_cluster.py	75.43% <91.66%> (+0.28%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nicholasyang2022]

True or False is not a return code. Please do not name it as rc.