Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check recv topic before match attempt #108

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Check recv topic before match attempt #108

merged 2 commits into from
Jul 12, 2021

Conversation

jsccast
Copy link
Member

@jsccast jsccast commented Jul 9, 2021

Closes #104.

robertfarnum
robertfarnum reviewed Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@robertfarnum robertfarnum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of changes, cognitive complexity overload. I wonder if there is anyway to break up this function?

@jsccast
Copy link
Member Author

jsccast commented Jul 12, 2021

Lot's of changes, cognitive complexity overload. I wonder if there is anyway to break up this function?

Yeah, it looks bad, but it's really the same code that just indented for the conditional body.

But I still agree: see #109! I thought it'd be better to fix the topic handling separate from breaking up Recv.Exec.

@jsccast jsccast merged commit ad515e3 into Comcast:main Jul 12, 2021
@jsccast jsccast deleted the bugfix_recvtopic branch July 12, 2021 18:05
@jsccast jsccast mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertfarnum robertfarnum robertfarnum approved these changes

@rrapant rrapant Awaiting requested review from rrapant

@hemanjayam hemanjayam Awaiting requested review from hemanjayam

@dnalinikumar dnalinikumar Awaiting requested review from dnalinikumar

@carlos-loya carlos-loya Awaiting requested review from carlos-loya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Javascript function to fail a test
2 participants
@jsccast @robertfarnum