Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check recv topic before match attempt #108

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Check recv topic before match attempt #108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
febd0e3
Check recv topic before match attempt; closes #104
jsccast Jul 9, 2021
7227f76
Merge branch 'main' into bugfix_recvtopic
jsccast Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 10 additions & 37 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,12 @@
# Recent changes

## New `httpserver` channel

See [`demos/http.yaml`](demos/http.yaml) and
[`demos/httpserver.yaml`](demos/httpserver.yaml) for examples.

## `httpclient` channel request and response improvements

## `@@` and `!!` syntax changes

Now do

1. `{@@filename}` instead of `@@filename` and
1. `{!!javascript!!}` instead of `!!javascript`.


## `HTTPClient` channel request and response

The request message now has lower-case properties instead of
capitalized properties.

The response message has structure supporting status code, body, and
headers. Sadly this change is not backwards-compatible.


## Schema validation

`pub` and `recv` now support a `schema` property, which gives a URI to
a JSON Schema that's used to validate the message.


## `serialization` properties for `pub` and `recv`

You can specify how `pub` and `recv` serialize messages by giving a
`serialization` property, which should either be `JSON` (the default)
or `string`.


## `recv` topic actually considered

Due to a bug, a `recv` topic, if given, was not considered correctly.
In some cases, a match could result from a message with a topic not
equal to the given topic. The current code fixes that bug. If you
have a test that now fails and didn't previously, check if you are
specifying a topic for each `recv`. In those cases, either adjust the
topic or remove the topic specification and check the message topic in
a guard (via `msg`, which has a value like
`{"topic":TOPIC,"payload":PAYLOAD}`).
Loading