test(minimap): guard destroy interval pause - #15532
Conversation
🎨 Storybook: 🚧 Building...🎭 Playwright: ⏳ Running... |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe minimap destruction test now clears interval-pause calls made during initialization and verifies that destruction pauses the change-detection interval exactly once. The existing request-animation-frame pause assertion remains unchanged. ChangesMinimap test validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized test-only change strengthens coverage for minimap cleanup behavior without changing production code or runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
destroy()performs exactly one additional pauseshouldPollpauseCloses #15278
Test plan
pauseChangeDetection()fromdestroy()makes the guarded test fail with 0 calls instead of 1pnpm exec vitest run src/renderer/extensions/minimap/composables/useMinimap.test.tspnpm exec oxfmt --check src/renderer/extensions/minimap/composables/useMinimap.test.tspnpm exec oxlint src/renderer/extensions/minimap/composables/useMinimap.test.ts --type-awarepnpm exec eslint src/renderer/extensions/minimap/composables/useMinimap.test.ts --cachepnpm typecheck