Skip to content

test(minimap): guard destroy interval pause #15532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yzxcj797 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

test(minimap): guard destroy interval pause #15532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/renderer/extensions/minimap/composables/useMinimap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,12 +425,15 @@ describe('useMinimap', () => {
const minimap = await createAndInitializeMinimap()

await minimap.init()
// The shouldPoll watcher already pauses once while inactive during
// setup. Clear that call so this assertion catches the destroy path.
mockIntervalPause.mockClear()
minimap.destroy()

// Both loops: rAF drives viewport sync, the interval drives change
// detection. One spy each, or deleting either pause here goes unnoticed.
expect(mockPause).toHaveBeenCalled()
expect(mockIntervalPause).toHaveBeenCalled()
expect(mockIntervalPause).toHaveBeenCalledTimes(1)
expect(api.removeEventListener).toHaveBeenCalledWith(
'graphChanged',
expect.any(Function)
Expand Down
Loading