Skip to content

fix(website): link supported-models and supported-nodes cards to cano… - #15546

Open
balpreetgrowthnatives wants to merge 1 commit into
Comfy-Org:mainfrom
balpreetgrowthnatives:fix/seo-orphan-page-trailing-slash
Open

fix(website): link supported-models and supported-nodes cards to cano…#15546
balpreetgrowthnatives wants to merge 1 commit into
Comfy-Org:mainfrom
balpreetgrowthnatives:fix/seo-orphan-page-trailing-slash

Conversation

@balpreetgrowthnatives

Copy link
Copy Markdown
Contributor

Summary

Internal links from the /p/supported-models/ and /cloud/supported-nodes/ index pages
omitted the trailing slash, while every page's own canonical tag (built by
absoluteUrl() in utils/jsonLd.ts) always includes one. On-page links therefore
pointed at a URL string distinct from each page's declared canonical — consistent
with SEO tooling reporting these pages as having no internal links pointing at them.
Fix: append the trailing slash to both link sources so they match the canonical URL.

Pages Affected

  • comfy.org/p/supported-models/* (all model detail pages, e.g. /p/supported-models/clip-vision-h/) — linked from src/pages/p/supported-models/index.astro
  • comfy.org/cloud/supported-nodes/* (all pack detail pages) — linked from src/components/cloud-nodes/PackCard.vue
  • comfy.org/zh-CN/cloud/supported-nodes/* (localized pack detail pages) — same component, zh-CN branch

…nical trailing-slash URLs

Internal links from the /p/supported-models/ and /cloud/supported-nodes/
index pages omitted the trailing slash, while every page's own canonical
tag (built by absoluteUrl() in utils/jsonLd.ts) always includes one. The
mismatch meant on-page links pointed at a URL distinct from the one each
page declares as canonical, which is consistent with an SEO crawl
reporting these pages as having no internal links pointing at them.
@balpreetgrowthnatives
balpreetgrowthnatives requested a review from a team August 21, 2026 09:22
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 21, 2026
@github-actions

Copy link
Copy Markdown

🎭 Playwright: ⏳ Running...

@github-actions

Copy link
Copy Markdown

🎨 Storybook: 🚧 Building...

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 714f161a-2f89-40c1-99ac-f802b06e7d29

📥 Commits

Reviewing files that changed from the base of the PR and between bb47e34 and 8aca73a.

📒 Files selected for processing (3)
  • apps/website/e2e/cloud-nodes.spec.ts
  • apps/website/src/components/cloud-nodes/PackCard.vue
  • apps/website/src/pages/p/supported-models/index.astro

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The website now generates pack and supported-model URLs with trailing slashes. English and Chinese cloud-node end-to-end assertions match the updated URL format. Pack card utility classes were reordered without behavior changes.

Changes

URL Alignment

Layer / File(s) Summary
Update website links
apps/website/src/components/cloud-nodes/PackCard.vue, apps/website/src/pages/p/supported-models/index.astro
Pack and supported-model links now include trailing slashes. Pack card utility classes were reordered without changing rendered behavior.
Align URL assertions
apps/website/e2e/cloud-nodes.spec.ts
English and Chinese cloud-node detail-page assertions now require trailing slashes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8aca7

This localized change aligns internal links with canonical trailing-slash URLs; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: mobeenabdullah


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Website End-To-End Regression Coverage ❓ Inconclusive The changed files are listed, but commit subjects are not available in the review context, so the check requires inconclusive status. Provide the PR commit subjects, then reassess the website runtime changes and the related Playwright coverage.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the website link updates for supported models and supported nodes.
Description check ✅ Passed The description explains the problem, the fix, the affected pages, and the canonical URL requirement.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The listed changes are exclusively under apps/website, which the check explicitly excludes from failure; the PR description also explains the URL mismatch and fix.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are website pages and components. None are under src/lib/litegraph/, src/ecs/, or graph-entity files, so this check does not apply.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant