Skip to content

fix(website): link supported-models and supported-nodes cards to cano… #15546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balpreetgrowthnatives wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

fix(website): link supported-models and supported-nodes cards to cano… #15546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/website/e2e/cloud-nodes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ test.describe('Cloud nodes page @smoke', () => {

await firstCard.locator('a').first().click()

await expect(page).toHaveURL(/\/cloud\/supported-nodes\/[a-z0-9-]+$/)
await expect(page).toHaveURL(/\/cloud\/supported-nodes\/[a-z0-9-]+\/$/)
await expect(page.getByTestId('cloud-node-pack-detail')).toBeVisible()
})

Expand Down Expand Up @@ -163,7 +163,9 @@ test.describe('Cloud nodes page (zh-CN) @smoke', () => {

await firstCard.locator('a').first().click()

await expect(page).toHaveURL(/\/zh-CN\/cloud\/supported-nodes\/[a-z0-9-]+$/)
await expect(page).toHaveURL(
/\/zh-CN\/cloud\/supported-nodes\/[a-z0-9-]+\/$/
)
await expect(page.getByTestId('cloud-node-pack-detail')).toBeVisible()
})
})
10 changes: 5 additions & 5 deletions apps/website/src/components/cloud-nodes/PackCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ const { locale = 'en', pack } = defineProps<{

const detailHref =
locale === 'zh-CN'
? `/zh-CN/cloud/supported-nodes/${pack.id}`
: `/cloud/supported-nodes/${pack.id}`
? `/zh-CN/cloud/supported-nodes/${pack.id}/`
: `/cloud/supported-nodes/${pack.id}/`

function nodeCountLabel(nodeCount: number): string {
const key =
Expand All @@ -27,7 +27,7 @@ function nodeCountLabel(nodeCount: number): string {

<template>
<article
class="bg-transparency-white-t5 border-primary-warm-gray/20 flex h-full flex-col overflow-hidden rounded-3xl border"
class="bg-transparency-white-t5 flex h-full flex-col overflow-hidden rounded-3xl border border-primary-warm-gray/20"
data-testid="cloud-node-pack-card"
>
<PackBanner
Expand All @@ -38,7 +38,7 @@ function nodeCountLabel(nodeCount: number): string {

<div class="flex flex-1 flex-col gap-5 p-5 md:p-6">
<div class="flex flex-col gap-2">
<h3 class="text-primary-comfy-canvas text-2xl/tight font-semibold">
<h3 class="text-2xl/tight font-semibold text-primary-comfy-canvas">
<a
:href="detailHref"
class="hover:text-primary-comfy-yellow"
Expand All @@ -47,7 +47,7 @@ function nodeCountLabel(nodeCount: number): string {
{{ pack.displayName }}
</a>
</h3>
<p class="text-primary-warm-gray text-sm/relaxed">
<p class="text-sm/relaxed text-primary-warm-gray">
{{
pack.description ||
t('cloudNodes.card.unavailableDescription', locale)
Expand Down
2 changes: 1 addition & 1 deletion apps/website/src/pages/p/supported-models/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const dirLabel: Record<string, string> = {
{models.map((model) => (
<li>
<a
href={`/p/supported-models/${model.slug}`}
href={`/p/supported-models/${model.slug}/`}
class="flex h-full flex-col gap-3 rounded-xl border border-white/10 p-5 transition-colors hover:border-white/25 hover:bg-white/5"
>
<div class="flex items-start justify-between gap-2">
Expand Down
Loading