test: inventory ECS expected failures by DrJKL · Pull Request #15609 · Comfy-Org/ComfyUI_frontend

DrJKL · 2026-08-22T04:13:01Z

Summary

import Christian's compatibility reproducers from test: reproduce #15577 and #15581 on the ECS branch #15592, test: pin the comfyui-promptchain slot-replacement break to the read path #15595, and test: pin LLink spread-copy topology loss as it.fails #15597
promote five .fails() cases fixed by parent PR fix: address ECS migration review findings #15610 to ordinary passing tests
inventory the eight remaining expected failures by fix boundary

Remaining work

2 legacy slot-link creation tests
4 input-slot realignment tests (ECS branch: one unmatched input name abandons a whole node's input-slot realignment on load #15581)
2 enumerable LLink topology tests (ECS migration: {...link} drops every LLink topology field, silently deleting connections in ComfyUI-Custom-Scripts #15594)

Testing

pnpm test:unit src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts src/lib/litegraph/src/linkDeduplication.conflictingOrigins.test.ts src/lib/litegraph/src/node/legacySlotLinkMutations.test.ts src/lib/litegraph/src/LLink.spreadCopy.test.ts
pnpm lint
pnpm format:check
pnpm typecheck
pnpm knip

Child of #15610.

coderabbitai · 2026-08-22T04:13:10Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a826adec-776e-4b1d-a4f5-edf16191f5d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-22T04:13:26Z

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/22/2026, 04:15:00 AM UTC

Links

📊 View Workflow Run

🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky

📊 Browser Reports

chromium: View Report (✅ 1968 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 13ms TBT · 86.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 19ms TBT · 93.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 139ms TBT · 92.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 10ms TBT · 74.4 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.8 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 158ms TBT · 173.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values

Metric	Value
canvas-idle: avg frame time	17ms
canvas-idle: p95 frame time	17ms
canvas-idle: layout duration	0ms
canvas-idle: style recalc duration	7ms
canvas-idle: layout count	0
canvas-idle: style recalc count	7
canvas-idle: task duration	521ms
canvas-idle: script duration	10ms
canvas-idle: TBT	0ms
canvas-idle: heap used	75.5 MB
canvas-idle: DOM nodes	-281
canvas-idle: event listeners	-155
canvas-mouse-sweep: avg frame time	17ms
canvas-mouse-sweep: p95 frame time	17ms
canvas-mouse-sweep: layout duration	4ms
canvas-mouse-sweep: style recalc duration	43ms
canvas-mouse-sweep: layout count	12
canvas-mouse-sweep: style recalc count	79
canvas-mouse-sweep: task duration	1444ms
canvas-mouse-sweep: script duration	215ms
canvas-mouse-sweep: TBT	0ms
canvas-mouse-sweep: heap used	72.3 MB
canvas-mouse-sweep: DOM nodes	-281
canvas-mouse-sweep: event listeners	-156
canvas-zoom-sweep: avg frame time	17ms
canvas-zoom-sweep: p95 frame time	17ms
canvas-zoom-sweep: layout duration	1ms
canvas-zoom-sweep: style recalc duration	18ms
canvas-zoom-sweep: layout count	6
canvas-zoom-sweep: style recalc count	32
canvas-zoom-sweep: task duration	353ms
canvas-zoom-sweep: script duration	11ms
canvas-zoom-sweep: TBT	0ms
canvas-zoom-sweep: heap used	72.1 MB
canvas-zoom-sweep: DOM nodes	77
canvas-zoom-sweep: event listeners	19
dom-widget-clipping: avg frame time	17ms
dom-widget-clipping: p95 frame time	17ms
dom-widget-clipping: layout duration	0ms
dom-widget-clipping: style recalc duration	6ms
dom-widget-clipping: layout count	0
dom-widget-clipping: style recalc count	9
dom-widget-clipping: task duration	457ms
dom-widget-clipping: script duration	40ms
dom-widget-clipping: TBT	0ms
dom-widget-clipping: heap used	63.7 MB
dom-widget-clipping: DOM nodes	14
dom-widget-clipping: event listeners	2
large-graph-idle: avg frame time	17ms
large-graph-idle: p95 frame time	17ms
large-graph-idle: layout duration	0ms
large-graph-idle: style recalc duration	1ms
large-graph-idle: layout count	0
large-graph-idle: style recalc count	1
large-graph-idle: task duration	544ms
large-graph-idle: script duration	39ms
large-graph-idle: TBT	0ms
large-graph-idle: heap used	73.9 MB
large-graph-idle: DOM nodes	-276
large-graph-idle: event listeners	-168
large-graph-pan: avg frame time	17ms
large-graph-pan: p95 frame time	17ms
large-graph-pan: layout duration	0ms
large-graph-pan: style recalc duration	8ms
large-graph-pan: layout count	0
large-graph-pan: style recalc count	62
large-graph-pan: task duration	3321ms
large-graph-pan: script duration	1258ms
large-graph-pan: TBT	0ms
large-graph-pan: heap used	92.4 MB
large-graph-pan: DOM nodes	-278
large-graph-pan: event listeners	-84
large-graph-zoom: avg frame time	17ms
large-graph-zoom: p95 frame time	17ms
large-graph-zoom: layout duration	8ms
large-graph-zoom: style recalc duration	12ms
large-graph-zoom: layout count	60
large-graph-zoom: style recalc count	66
large-graph-zoom: task duration	3046ms
large-graph-zoom: script duration	1119ms
large-graph-zoom: TBT	13ms
large-graph-zoom: heap used	86.8 MB
large-graph-zoom: DOM nodes	24
large-graph-zoom: event listeners	12
legacy-node-drag: avg frame time	17ms
legacy-node-drag: p95 frame time	17ms
legacy-node-drag: layout duration	0ms
legacy-node-drag: style recalc duration	5ms
legacy-node-drag: layout count	0
legacy-node-drag: style recalc count	41
legacy-node-drag: task duration	2427ms
legacy-node-drag: script duration	261ms
legacy-node-drag: TBT	19ms
legacy-node-drag: heap used	93.3 MB
legacy-node-drag: DOM nodes	0
legacy-node-drag: event listeners	189
minimap-idle: avg frame time	17ms
minimap-idle: p95 frame time	17ms
minimap-idle: layout duration	0ms
minimap-idle: style recalc duration	1ms
minimap-idle: layout count	0
minimap-idle: style recalc count	1
minimap-idle: task duration	530ms
minimap-idle: script duration	39ms
minimap-idle: TBT	0ms
minimap-idle: heap used	74.0 MB
minimap-idle: DOM nodes	-276
minimap-idle: event listeners	-183
subgraph-dom-widget-clipping: avg frame time	17ms
subgraph-dom-widget-clipping: p95 frame time	17ms
subgraph-dom-widget-clipping: layout duration	0ms
subgraph-dom-widget-clipping: style recalc duration	10ms
subgraph-dom-widget-clipping: layout count	0
subgraph-dom-widget-clipping: style recalc count	46
subgraph-dom-widget-clipping: task duration	541ms
subgraph-dom-widget-clipping: script duration	157ms
subgraph-dom-widget-clipping: TBT	0ms
subgraph-dom-widget-clipping: heap used	65.0 MB
subgraph-dom-widget-clipping: DOM nodes	18
subgraph-dom-widget-clipping: event listeners	7
subgraph-idle: avg frame time	17ms
subgraph-idle: p95 frame time	17ms
subgraph-idle: layout duration	0ms
subgraph-idle: style recalc duration	9ms
subgraph-idle: layout count	0
subgraph-idle: style recalc count	10
subgraph-idle: task duration	504ms
subgraph-idle: script duration	9ms
subgraph-idle: TBT	0ms
subgraph-idle: heap used	63.1 MB
subgraph-idle: DOM nodes	-296
subgraph-idle: event listeners	-216
subgraph-mouse-sweep: avg frame time	17ms
subgraph-mouse-sweep: p95 frame time	17ms
subgraph-mouse-sweep: layout duration	5ms
subgraph-mouse-sweep: style recalc duration	39ms
subgraph-mouse-sweep: layout count	16
subgraph-mouse-sweep: style recalc count	77
subgraph-mouse-sweep: task duration	1162ms
subgraph-mouse-sweep: script duration	129ms
subgraph-mouse-sweep: TBT	0ms
subgraph-mouse-sweep: heap used	65.3 MB
subgraph-mouse-sweep: DOM nodes	-297
subgraph-mouse-sweep: event listeners	-200
subgraph-transition-enter: avg frame time	17ms
subgraph-transition-enter: p95 frame time	17ms
subgraph-transition-enter: layout duration	15ms
subgraph-transition-enter: style recalc duration	32ms
subgraph-transition-enter: layout count	14
subgraph-transition-enter: style recalc count	19
subgraph-transition-enter: task duration	900ms
subgraph-transition-enter: script duration	39ms
subgraph-transition-enter: TBT	139ms
subgraph-transition-enter: heap used	92.9 MB
subgraph-transition-enter: DOM nodes	13671
subgraph-transition-enter: event listeners	2381
viewport-pan-sweep: avg frame time	17ms
viewport-pan-sweep: p95 frame time	17ms
viewport-pan-sweep: layout duration	0ms
viewport-pan-sweep: style recalc duration	32ms
viewport-pan-sweep: layout count	0
viewport-pan-sweep: style recalc count	243
viewport-pan-sweep: task duration	11679ms
viewport-pan-sweep: script duration	4471ms
viewport-pan-sweep: TBT	10ms
viewport-pan-sweep: heap used	74.4 MB
viewport-pan-sweep: DOM nodes	-276
viewport-pan-sweep: event listeners	-56
vue-large-graph-idle: avg frame time	18ms
vue-large-graph-idle: p95 frame time	17ms
vue-large-graph-idle: layout duration	0ms
vue-large-graph-idle: style recalc duration	0ms
vue-large-graph-idle: layout count	0
vue-large-graph-idle: style recalc count	0
vue-large-graph-idle: task duration	16638ms
vue-large-graph-idle: script duration	357ms
vue-large-graph-idle: TBT	0ms
vue-large-graph-idle: heap used	167.8 MB
vue-large-graph-idle: DOM nodes	-6548
vue-large-graph-idle: event listeners	-7474
vue-large-graph-pan: avg frame time	18ms
vue-large-graph-pan: p95 frame time	17ms
vue-large-graph-pan: layout duration	0ms
vue-large-graph-pan: style recalc duration	19ms
vue-large-graph-pan: layout count	0
vue-large-graph-pan: style recalc count	173
vue-large-graph-pan: task duration	20894ms
vue-large-graph-pan: script duration	1057ms
vue-large-graph-pan: TBT	158ms
vue-large-graph-pan: heap used	173.7 MB
vue-large-graph-pan: DOM nodes	-6548
vue-large-graph-pan: event listeners	-7469
workflow-execution: avg frame time	17ms
workflow-execution: p95 frame time	17ms
workflow-execution: layout duration	1ms
workflow-execution: style recalc duration	19ms
workflow-execution: layout count	5
workflow-execution: style recalc count	12
workflow-execution: task duration	116ms
workflow-execution: script duration	6ms
workflow-execution: TBT	0ms
workflow-execution: heap used	69.0 MB
workflow-execution: DOM nodes	122
workflow-execution: event listeners	61

Raw data

{
  "timestamp": "2026-08-22T04:26:45.384Z",
  "gitSha": "a76f4f32874408f313eabb8b6f97a540125dcb6e",
  "branch": "test/ecs-fails-inventory",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2051.6300000000456,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.524,
      "heapDeltaBytes": 5437536,
      "heapUsedBytes": 76456620,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.617,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.8539999999857,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.681000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.991,
      "heapDeltaBytes": 11093152,
      "heapUsedBytes": 81902480,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.615,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2499.129000000039,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 46.73,
      "layouts": 12,
      "layoutDurationMs": 4.776000000000001,
      "taskDurationMs": 1572.5390000000002,
      "heapDeltaBytes": 6166900,
      "heapUsedBytes": 77058644,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 230.73000000000002,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2236.8569999999863,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.109,
      "layouts": 12,
      "layoutDurationMs": 3.4029999999999996,
      "taskDurationMs": 1315.339,
      "heapDeltaBytes": 3835872,
      "heapUsedBytes": 74669380,
      "domNodes": -283,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 199.78900000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.4180000000047,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.667,
      "layouts": 6,
      "layoutDurationMs": 0.6569999999999999,
      "taskDurationMs": 356.788,
      "heapDeltaBytes": 4180560,
      "heapUsedBytes": 76030284,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.941,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.7560000000803,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.175,
      "layouts": 6,
      "layoutDurationMs": 0.5879999999999999,
      "taskDurationMs": 348.56699999999995,
      "heapDeltaBytes": 4197540,
      "heapUsedBytes": 75072248,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.84,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 714.4910000000095,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.182999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.093,
      "heapDeltaBytes": -3946144,
      "heapUsedBytes": 66823844,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 40.867,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 725.5740000000515,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.687999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.09700000000004,
      "heapDeltaBytes": -3918340,
      "heapUsedBytes": 66660756,
      "domNodes": 14,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 39.254000000000005,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.4540000000206,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.0769999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.0749999999999,
      "heapDeltaBytes": -11935072,
      "heapUsedBytes": 77999312,
      "domNodes": -274,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 37.931,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.9349999999768,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.0450000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 532.8320000000001,
      "heapDeltaBytes": -12362612,
      "heapUsedBytes": 76983636,
      "domNodes": -277,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 41.062,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 4238.805999999954,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.143,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3443.35,
      "heapDeltaBytes": 31796004,
      "heapUsedBytes": 97122772,
      "domNodes": -279,
      "jsHeapTotalBytes": 5406720,
      "scriptDurationMs": 1293.646,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 4232.417000000055,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.876999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3198.5490000000004,
      "heapDeltaBytes": 31000632,
      "heapUsedBytes": 96754960,
      "domNodes": -277,
      "jsHeapTotalBytes": 5668864,
      "scriptDurationMs": 1222.3540000000003,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 5205.175999999994,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.818000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.865,
      "taskDurationMs": 3129.5299999999997,
      "heapDeltaBytes": 20062352,
      "heapUsedBytes": 90967036,
      "domNodes": 24,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 1144.21,
      "eventListeners": 12,
      "totalBlockingTimeMs": 22,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4923.956999999973,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.514999999999997,
      "layouts": 60,
      "layoutDurationMs": 7.477,
      "taskDurationMs": 2963.4449999999997,
      "heapDeltaBytes": 20094024,
      "heapUsedBytes": 91028928,
      "domNodes": 24,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 1093.53,
      "eventListeners": 12,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3656.540000000007,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.702000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2549.0389999999998,
      "heapDeltaBytes": 31275916,
      "heapUsedBytes": 100682136,
      "domNodes": 0,
      "jsHeapTotalBytes": 1916928,
      "scriptDurationMs": 298.29499999999996,
      "eventListeners": 190,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3271.543999999949,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.657000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2305.48,
      "heapDeltaBytes": 26347556,
      "heapUsedBytes": 94920912,
      "domNodes": 0,
      "jsHeapTotalBytes": 4276224,
      "scriptDurationMs": 224.209,
      "eventListeners": 188,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.3560000000352,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.0299999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.8279999999999,
      "heapDeltaBytes": -13065904,
      "heapUsedBytes": 77454024,
      "domNodes": -275,
      "jsHeapTotalBytes": -2433024,
      "scriptDurationMs": 38.708000000000006,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2026.8939999999702,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.843,
      "heapDeltaBytes": -13050288,
      "heapUsedBytes": 77632204,
      "domNodes": -277,
      "jsHeapTotalBytes": -1646592,
      "scriptDurationMs": 39.003,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 763.4909999999877,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.818,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.408,
      "heapDeltaBytes": -4581348,
      "heapUsedBytes": 68874704,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 159.195,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 746.3810000000421,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.442000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.462,
      "heapDeltaBytes": -5060052,
      "heapUsedBytes": 67384952,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 155.616,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2029.9890000000005,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.552999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.366,
      "heapDeltaBytes": -12012536,
      "heapUsedBytes": 60113676,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.088,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.0139999999228,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.605,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.772,
      "heapDeltaBytes": -299628,
      "heapUsedBytes": 72142848,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.341,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1922.8430000000003,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.108,
      "layouts": 16,
      "layoutDurationMs": 4.923,
      "taskDurationMs": 1198.0279999999998,
      "heapDeltaBytes": -7879940,
      "heapUsedBytes": 65386848,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 134.10300000000004,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1873.5319999999547,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.257,
      "layouts": 16,
      "layoutDurationMs": 4.32,
      "taskDurationMs": 1126.617,
      "heapDeltaBytes": -1199500,
      "heapUsedBytes": 71520116,
      "domNodes": -297,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 123.422,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6070000000364,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.784999999999993,
      "layouts": 14,
      "layoutDurationMs": 14.567,
      "taskDurationMs": 900.3729999999998,
      "heapDeltaBytes": 132880,
      "heapUsedBytes": 97419424,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 38.790000000000006,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 14957.2,
      "styleRecalcs": 242,
      "styleRecalcDurationMs": 31.386000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11313.738000000001,
      "heapDeltaBytes": 5986672,
      "heapUsedBytes": 71987792,
      "domNodes": -276,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 4235.633,
      "eventListeners": 38,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 16101.887000000033,
      "styleRecalcs": 243,
      "styleRecalcDurationMs": 32.611000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12043.846,
      "heapDeltaBytes": -5332964,
      "heapUsedBytes": 84108124,
      "domNodes": -276,
      "jsHeapTotalBytes": 8097792,
      "scriptDurationMs": 4705.951,
      "eventListeners": -149,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16944.560999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16438.130999999998,
      "heapDeltaBytes": -37458136,
      "heapUsedBytes": 176999972,
      "domNodes": -6548,
      "jsHeapTotalBytes": 614400,
      "scriptDurationMs": 329.492,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17624.79799999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16838.089,
      "heapDeltaBytes": -34066808,
      "heapUsedBytes": 174937480,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3706880,
      "scriptDurationMs": 383.532,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20962.43400000003,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 18.16300000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20550.505999999998,
      "heapDeltaBytes": -31903488,
      "heapUsedBytes": 181901284,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5267456,
      "scriptDurationMs": 1047.241,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21583.064000000035,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 19.921999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21238.288999999997,
      "heapDeltaBytes": -34351320,
      "heapUsedBytes": 182452976,
      "domNodes": -6548,
      "jsHeapTotalBytes": -9523200,
      "scriptDurationMs": 1065.875,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 198,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 123.78000000001066,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 16.493000000000002,
      "layouts": 7,
      "layoutDurationMs": 1.607,
      "taskDurationMs": 100.99999999999999,
      "heapDeltaBytes": 3541428,
      "heapUsedBytes": 70998440,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.205000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 487.20800000000963,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 21.609,
      "layouts": 3,
      "layoutDurationMs": 0.792,
      "taskDurationMs": 130.29000000000002,
      "heapDeltaBytes": 5872876,
      "heapUsedBytes": 73702904,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.4990000000000006,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

codecov · 2026-08-22T04:29:59Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/lib/litegraph/src/linkDeduplication.ts	0.00%	1 Missing ⚠️

@@                   Coverage Diff                    @@
##           fix/ecs-review-findings   #15609   +/-   ##
========================================================
  Coverage                    82.36%   82.36%           
========================================================
  Files                         1908     1908           
  Lines                       108303   108304    +1     
  Branches                     30243    30243           
========================================================
+ Hits                         89205    89209    +4     
+ Misses                       18769    18754   -15     
- Partials                       329      341   +12

Flag	Coverage Δ
e2e	`68.16% <0.00%> (+<0.01%)`	⬆️
unit	`74.02% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/lib/litegraph/src/linkDeduplication.ts	`80.43% <0.00%> (ø)`

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Amp-Thread-ID: https://ampcode.com/threads/T-01a02705-02f3-70c9-ae5b-8ea6c2a3cac2

DrJKL requested review from AustinMroz and christian-byrne August 22, 2026 04:13

DrJKL mentioned this pull request Aug 22, 2026

fix: address ECS migration review findings #15605

Closed

github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 22, 2026

DrJKL added the refactor label Aug 22, 2026

DrJKL assigned christian-byrne Aug 22, 2026

DrJKL force-pushed the fix/ecs-review-findings branch from 16a2968 to d4dbe7e Compare August 22, 2026 07:59

docs: inventory ECS expected failures

6c433a5

Amp-Thread-ID: https://ampcode.com/threads/T-01a02705-02f3-70c9-ae5b-8ea6c2a3cac2

DrJKL force-pushed the test/ecs-fails-inventory branch from b91396e to 6c433a5 Compare August 22, 2026 08:01

DrJKL closed this Aug 22, 2026

DrJKL deleted the test/ecs-fails-inventory branch August 22, 2026 08:05

github-actions Bot added risk:R1 PR risk grade (advisory shadow check; grader-owned) and removed risk:R2 PR risk grade (advisory shadow check; grader-owned) labels Aug 22, 2026

Navigation Menu

Uh oh!

test: inventory ECS expected failures - #15609

test: inventory ECS expected failures#15609
DrJKL wants to merge 1 commit into
fix/ecs-review-findingsfrom
test/ecs-fails-inventory

DrJKL commented Aug 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 22, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

DrJKL commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Remaining work

Testing

Uh oh!

coderabbitai Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook: ✅ Built — View Storybook

🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky

📦 Bundle Size

⚡ Performance Report

Uh oh!

codecov Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DrJKL commented Aug 22, 2026 •

edited

Loading

coderabbitai Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

codecov Bot commented Aug 22, 2026 •

edited

Loading