Skip to content

test: inventory ECS expected failures #15609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DrJKL wants to merge 1 commit into from
+30 −0
Closed

test: inventory ECS expected failures #15609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions docs/architecture/ecs/ecs-expected-failure-inventory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# ECS expected-failure inventory

This inventory covers the compatibility regressions marked with Vitest
`.fails()` on the ECS migration stack and its reproduction PRs. A marker should
be removed only after the same test passes as a plain `it()` test.

## Activated by this stack

Five reproduction tests now pass normally:

| Source | Tests | Resolution |
| --------------- | ----: | ------------------------------------------------------------------------------------------------------------------------------------------- |
| #15592 / #15577 | 3 | Preserve the input-referenced link through deduplication, retain it through serialization, and identify the occupied target in the warning. |
| #15595 | 2 | Rehydrate indexed plain-object input slots so spread copies retain live connectivity. |

## Remaining expected failures

Eight tests remain marked `.fails()`:

| Area | Tests | Required fix |
| ------------------------------------ | ----: | ------------------------------------------------------------------------------------------------------------- |
| Legacy slot link creation | 2 | Proxy additions through `input.link` and `output.links` into link-store registration, not only removals. |
| Input-slot realignment (#15581) | 4 | Remove or relocate unmatched blockers in the same topology update so valid sibling moves land without errors. |
| Enumerable `LLink` topology (#15594) | 2 | Expose topology fields as own enumerable properties so link spread copies preserve their endpoints. |

The markers live in:

- `src/lib/litegraph/src/node/legacySlotLinkMutations.test.ts`
- `src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`
- `src/lib/litegraph/src/LLink.spreadCopy.test.ts`
Loading