Adjust popup media element dimensions #2675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the `HeightRequest` from 600 to 300 and the `WidthRequest` from 600 to 800 for the `popupMediaElement`, resulting in a shorter and wider display in the popup. This fixes controls bar that had the left and right edges cut off in sample app.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the dimensions of the popup media element to provide a shorter and wider display, resolving an issue where the control bar's left and right edges were being cut off.
- Updated HeightRequest from 600 to 300
- Updated WidthRequest from 600 to 800
Comment on lines
+254
to
+255
| HeightRequest = 300, | ||
| WidthRequest = 800, |
There was a problem hiding this comment.
[nitpick] Consider extracting these dimension values into constants to improve maintainability and consistency across UI components.
Suggested change
| HeightRequest = 300, | |
| WidthRequest = 800, | |
| HeightRequest = PopupHeight, | |
| WidthRequest = PopupWidth, |
Collaborator
|
The Popup Video is now clipped on iOS.
In your video, the MediaElement is clipped in the Popup. This likely means that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changed the
HeightRequestfrom 600 to 300 and theWidthRequestfrom 600 to 800 for thepopupMediaElement, resulting in a shorter and wider display in the popup.This fixes controls bar that had the left and right edges cut off in sample app.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR