Skip to content

Adjust popup media element dimensions #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ne0rrmatrix wants to merge 2 commits into from
Closed

Adjust popup media element dimensions #2675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfec066
Adjust popup media element dimensions
ne0rrmatrix May 27, 2025
5411dab
Merge branch 'main' into FixMediaElementPopupDimensions
ne0rrmatrix May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ async void DisplayPopup(object sender, EventArgs e)
{
AndroidViewType = AndroidViewType.SurfaceView,
Source = MediaSource.FromResource("AppleVideo.mp4"),
MetadataArtworkUrl = botImageUrl,
HeightRequest = 300,
WidthRequest = 800,
Comment on lines +254 to +255
Copy link

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting these dimension values into constants to improve maintainability and consistency across UI components.

Suggested change
HeightRequest = 300,
WidthRequest = 800,
HeightRequest = PopupHeight,
WidthRequest = PopupWidth,

Copilot uses AI. Check for mistakes.
ShouldAutoPlay = true,
ShouldShowPlaybackControls = true,
};
Expand Down
Loading