-
Notifications
You must be signed in to change notification settings - Fork 25
WIP: Simplify the static build #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/plt-scheduler-port
Are you sure you want to change the base?
Conversation
3286e37 to
3bae656
Compare
| jobs: | ||
| build-ghc: | ||
| name: Build ghc for linux x64 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need a more beefy runner
| upload: | ||
| name: Upload to S3 | ||
| runs-on: ubuntu-latest | ||
| environment: s3-push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proper environment needs to be setup
| ghc: | ||
| linux64-custom-static-build-tinfo6: | ||
| 9.10.2: | ||
| url: "/home/lime/Concordium/concordium-node/ghc2/ghc-9.10.2/_build/bindist/ghc-9.10.2-x86_64-unknown-linux.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the build-static-ghc workflow is working, this needs to point to the resource
|
|
||
| #[cfg(feature = "profiling")] | ||
| let path = format!("{}/deps/static-libs/linux/profiling", out_dir); | ||
| pub fn link_libraries() -> std::io::Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should mostly correspond to the logic found in scripts/static-libraries/build-static-libraries.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is mostly copy of the one here
2a4df30 to
b60f0ba
Compare
3bae656 to
81ac8d8
Compare
Purpose
The staticly linked binary for Linux has a lot of indirections, this PR aims to simplify it.
The release flow involves several docker images, making it hard to run locally.
The end goal is to be able to build the static linux build (potentially other platforms as well) using just:
Changes
stack.static.yamluse the custom GHC directly.scripts/static-libraries/build-static-libraries.shintobuild.rs. (still WIP)TODO changes
When new flow is working then:
scripts/static-binariesdir.scripts/static-librariesdir.scripts/build-binaries.sh.scripts/start.sh.