-
Notifications
You must be signed in to change notification settings - Fork 2
#611: Implement all update formulae and make them optionally usable #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
#611: Implement all update formulae and make them optionally usable #612
Conversation
|
@lifflander this is now fully working, and the optional choice to use the update formulae (or not) is determined by the use of the Currently, the debug verification is performed, by comparing the update vs. full recompute results; until we convince ourselves fully that the update formulae are correctly implemented (and no theoretical errors were made in the paper either...). Follow-on issues as created to keep track of these 2 points. |
|
@lifflander I made some additional testing following our recent conversation, no problem found. Still awaiting your review when you get a chance. |
lifflander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great. I've walked through all the update formula and I think they are correct.
…y detected with a configuration non even feasible to begin with and therefore not part of the test harness)
Resolves #611