Skip to content

#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 26, 2025
Merged

#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383

merged 12 commits into from
Feb 26, 2025

Conversation

@lifflander
Copy link
Collaborator

@lifflander lifflander commented Dec 18, 2024

Fixes #2382

@lifflander lifflander linked an issue Dec 18, 2024 that may be closed by this pull request
Fix performance issues with CCM-LB #2382
Closed
@lifflander lifflander force-pushed the 2382-fix-performance-issues-with-ccm-lb branch from 2ea8a29 to ccb3bb1 Compare December 18, 2024 23:42
@lifflander
Copy link
Collaborator Author

lifflander commented Dec 18, 2024

This might need a more complete treatment with a increasing backoff, but for now this code is running well.

@github-actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for 900f9aa (2024-12-23 22:43:15 UTC)

Compilation - successful

Testing - passed

Build log

@lifflander lifflander force-pushed the 2382-fix-performance-issues-with-ccm-lb branch 2 times, most recently from e7bd01a to 900f9aa Compare December 23, 2024 22:43
@lifflander lifflander marked this pull request as ready for review December 24, 2024 01:29
@cz4rs cz4rs self-requested a review January 7, 2025 18:30
cz4rs
cz4rs reviewed Jan 7, 2025
View reviewed changes
cz4rs
cz4rs reviewed Jan 7, 2025
View reviewed changes
cz4rs
cz4rs reviewed Jan 7, 2025
View reviewed changes
cz4rs
cz4rs approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Needs a rebase too.

For any potential reviewer: using Hide whitespace helps a lot 😉

@lifflander lifflander force-pushed the 2382-fix-performance-issues-with-ccm-lb branch from 900f9aa to 7f2f5b0 Compare February 25, 2025 23:43
@lifflander lifflander merged commit 6b13039 into develop Feb 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cz4rs cz4rs cz4rs approved these changes

@ppebay ppebay Awaiting requested review from ppebay

@nlslatt nlslatt Awaiting requested review from nlslatt

@pierrepebay pierrepebay Awaiting requested review from pierrepebay

@cwschilly cwschilly Awaiting requested review from cwschilly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix performance issues with CCM-LB

3 participants

@lifflander @cz4rs